Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Timeout to low #1233

Closed
sinnbeck opened this issue Sep 11, 2024 · 7 comments · Fixed by pestphp/pest-plugin-mutate#15
Closed

[Bug]: Timeout to low #1233

sinnbeck opened this issue Sep 11, 2024 · 7 comments · Fixed by pestphp/pest-plugin-mutate#15
Labels

Comments

@sinnbeck
Copy link

sinnbeck commented Sep 11, 2024

What Happened

I am working with a filament app, but apparently the default timeout is too low. I am running in parallel, but almost all tests are timing out which means I cannot trust my tests at all

image

How to Reproduce

Have a complex filament page with a lot of form fields

Sample Repository

No response

Pest Version

3.0.4

PHP Version

8.3

Operation System

Linux

Notes

I am running the tests in docker (Lando).

It might be practical to allow overwriting the timeout with a flag or a setting in Pest.php

If I just manually change the timeout in the vendor folder it works
image

@sinnbeck sinnbeck added the bug label Sep 11, 2024
@danielh-official
Copy link

Could this work for you? --default-time-limit <sec>

https://pestphp.com/docs/cli-api-reference#content-execution

@sinnbeck
Copy link
Author

@danielh-official thanks for the suggestion but I just get The "--default-time-limit" option does not exist.

And I doubt it would work, as the values are hardcoded currently.
https://github.com/pestphp/pest-plugin-mutate/blob/3.x/src/MutationTest.php#L108

@gehrisandro
Copy link
Contributor

Hi @sinnbeck

Thanks for raising the issue.

Looks like we are missing the correct implementation there. I am going to fix that.

@gehrisandro
Copy link
Contributor

Issue will be fixed in the next release
pestphp/pest-plugin-mutate#15

@gehrisandro
Copy link
Contributor

@nunomaduro This issue can be closed.

@jonathanpmartins
Copy link

jonathanpmartins commented Sep 18, 2024

@gehrisandro Is there a way that we could set a custom timeout? Or a custom timeout offset on top of the calculated one?

@sinnbeck
Copy link
Author

I will see how the new version works and make a new issue if I run into any issues with that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants