Like console routing, need an ability for following protocols TCPIP, HTTP, gRPC routing

[Nilavarasi-Ashika]

Is your feature request related to a problem? Please describe.
Like console mode routing, we need the routing feature for these protocols TCPIP, HTTP, gRPC.

Runtime
OS: Linux
.NET 7.0.2
pi-cli 4.2.4-rc

[asperpint]

Thanks @Nilavarasi-Ashika, for reporting an issue. This is an enhancement request. Can you explain at a high level why you cannot implement a custom Http and gRPC routing service at your end? Our framework already supports custom routing services.

We already have TCP/IP routing service by default.

[pidevin]

@Nilavarasi-Ashika: We support UDP terminal router. Please validate and let us know your feedback.

The UDP feature will be released with version 5.10.x

[Nilavarasi-Ashika]

Please let us know when gRPC support will be available.
///

/// The terminal starts as a gRPC server that listens to an incoming message. NOT YET SUPPORTED.
///

Grpc = 3,

[perpetualintelligencegit]

@Nilavarasi-Ashika, we have started a discussion thread to integrate gRPC within terminal framework. We can provide an intermediate implementation with Grpc.Core but this package is due deprecation.

[perpetualintelligencegit]

@Nilavarasi-Ashika : We now have the gRPC implementation using the latest recommended approach grpc/grpc-dotnet#2543. This does not use the old Grpc.Core instead using AspNet.Core hosting. Please use the latest code in main branch and provide us feedback from your usage. We plan to release a Nuget package for 5.13.x by Oct-2024 end. To see the sample gRPC integration with terminal framework see https://github.com/perpetualintelligence/terminal/tree/main/apps/s2s

[perpetualintelligencegit]

@Nilavarasi-Ashika: Both gRPC and HTTP terminal routing as servers are now supported. We have added the following new packages:

OneImlx.Terminal --> Main Terminal framework package
OneImlx.Terminal.AspNetCore --> Hosting the HTTP or gRPC server
OneImlx.Terminal.Client --> Client applications (this can be console, ASP.NET, Blazor, Windows Forms or MAUI)
OneImxl.Terminal.Authenticaiton --> Terminal server authentication

As mentioned earlier we are targeting release on Oct-end please validate and let us know feedback,

[Nilavarasi-Ashika]

In Http protocol routing the response from server to client not performing. while verified in the code TerminalHttpAppExtensions MapTerminalHttp not returning response message with data to client, it just performing command routing.

[perpetualintelligencegit]

@Nilavarasi-Ashika: The syntax and naming of the API have changed, please verify the updated code for your use case. We are still reviewing your request for response handling. @prawasu please review this request.

[Nilavarasi-Ashika]

In TerminalConsoleRouter RunAsync method passing null for CommandRunnerContext.HandlerContext.RouterContext.Properites to ProcessAsync method inside the class CommandRunnerResultSendToFile.
Hence console mode routing getting the System.NullReferenceException: 'Object reference not set to an instance of an object.'.

[perpetualintelligencegit]

@Nilavarasi-Ashika: Fixed it there was an issue with sample app. Please check. We are working on the response handling as well.

[Nilavarasi-Ashika]

Please review the following issues observed in the latest code:

1. Instead of returning the route result, the method is returning route details. The TerminalRemoteQueue.Enqueue method returns a TerminalRemoteQueueRequest object, not the expected response message. This issue occurs across all modes of routing.

2. For HTTP, TCP, and UDP, the response is not being returned. The data is simply enqueued (containing only the route details as mentioned in point 1), but it is not being sent back to the client.

[perpetualintelligencegit]

@Nilavarasi-Ashika: We are working on providing a mechanism for asynchronous response handling along with gRPC and Http support. But this will be a breaking change. We have moved this to Nov end milestone. Please keep tracking the result branch for result and provide your feedback for testing.

[perpetualintelligencegit]

@Nilavarasi-Ashika: The response handling is implemented in the the result branch. Note these are breaking changes. Please fully test your application scenarios and give us feedback. We plan to release nuget packages by end of Nov.

[Nilavarasi-Ashika]

Verified result branch code and encounter below issues;

1. Regarding routing: TerminalProcessor StreamAsync method handling response from stream loop condition is invalid. Hence it's not enter into the loop to perform routing. Tcp and Udp routing still has issue, because TerminalTcpRouter and TerminalUdpRouter using this StreamAsync method in HandleClientConnectedAsync.

2. Udp Response Handling: In TerminalUdpRouter "StartProcessing(context, background: true, responseHandler: null)" not passing func delegate to response handler instead using null. Hence not getting response in Udp mode to client.

[perpetualintelligencegit]

@Nilavarasi-Ashika: Did you check our Sample App on how to use TCP with Streaming and Response handling. Http and gRPC are command and response protocols while TCP sends a stream of bytes so its response handling is separate.

Are you using UDP in your application to send and receive the response as well ?

[Nilavarasi-Ashika]

we are verified with TCP, gRPC and http. For all network type routing the command and response handling working as expected.
yes, we are using UDP also, issue in response handling.

[perpetualintelligencegit]

@Nilavarasi-Ashika: Thanks for your feedback. We have intentionally disabled the response handling for UDP (since it is fire and forget protocol). We will investigate and get back to you. Please note that we have moved the release for this issue to Dec-2024.

[perpetualintelligencegit]

@Nilavarasi-Ashika: We have published the preview 6.x.x. packages. Please verify and let us know testing feedback based on your application use. Note we are still working on UDP result processing.

[perpetualintelligencegit]

@Nilavarasi-Ashika: UDP response handling is implemented in latest RC NuGet package. Please verify and provide your feedback. We will be updating the documentation and preparing 6.x release.

[perpetualintelligencegit]

@Nilavarasi-Ashika: We have published all the new versions (rc) to NuGet. Note you will need to regenerate your license file for new packages. Please validate and let us know feedback. We plan to close this enhancement request and release package by Jan 15th.

[Nilavarasi-Ashika]

Please let us know when documentation will get updated for latest release.

[Nilavarasi-Ashika]

6.0.0-rc.250106412 verified the latest release and observed following items:

1. If an invalid command is provided, the routing enters a perpetual not handled (waiting state in application not allow to proceed) instead of returning an "Invalid Command" message.
2. Notifications for all types of routing connection events, such as connection establishment or disconnection, are not being displayed.

[Nilavarasi-Ashika]

Verified with UDP routing mechanism and encounter the command response data transmission restricted to 65KB. Need an ability to send larger size command response in the size of MB's.

[perpetualintelligencegit]

@Nilavarasi-Ashika: 65KB is UDP protocol limit. You will need to stream the higher data with Router's Stream API.

[perpetualintelligencegit]

6.0.0-rc.250106412 verified the latest release and observed following items:

1. If an invalid command is provided, the routing enters a perpetual not handled (waiting state in application not allow to proceed) instead of returning an "Invalid Command" message.
2. Notifications for all types of routing connection events, such as connection establishment or disconnection, are not being displayed.

@Nilavarasi-Ashika: Can you give a sample app to reproduce these issues ?

[perpetualintelligencegit]

@Nilavarasi-Ashika: We are unable to download content on our dev machines due to on-prem security requirements. Request you create git repo and share the repo link so we can clone it, scan it and reproduce the issue. I am going to delete the attachment.

Also please ensure you use OneImlx.Terminal.Client package for your client Apps.

[perpetualintelligencegit]

@Nilavarasi-Ashika: We are able to reproduce the issue where the result should be returned even if there is an error. We are working on the fix.