-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error expected on DataConnection when not establishing a connection #924
Labels
client
related to peerjs client
feature
suggestions for new features or enhancements
help wanted
looking for contributors
Comments
afrokick
added
help wanted
looking for contributors
feature
suggestions for new features or enhancements
labels
Feb 20, 2022
i need too. and now i use setTimeout instead. |
This also applies to the Responsible source code: Lines 390 to 395 in 633cd84
I think Promise-based API would make it easier to resolve this . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
client
related to peerjs client
feature
suggestions for new features or enhancements
help wanted
looking for contributors
When a DataConnection fails to establish, for example, due to connecting to an invalid ID or to one's own ID, I would expect the
dataConnection.on('error', () => {...})
callback to be executed. Instead, onlypeer.on('error', () => {})
catches such kinds of errors. This is especially annoying when you want to for example connect to multiple peers at once since we cannot know which one has failed to connect, making it hard to tell the user which peer(s) has issues.The text was updated successfully, but these errors were encountered: