Fix dependency tree in Makefile to ensure schema is built *after* it's dropped when running in parallel #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s dropped when running in parallel Previously showing an error on every second run: ``` ➜ make -j4 install [remove ] /home/brendan/.local/share/gnome-shell/extensions/[email protected] [extension ] OK Reloading extensions does not work correctly and is no longer supported [reload ] OK [remove ] OK [translate ] ar/ ca/ cs/ de/ es_ES/ es_MX/ fa/ fi/ fr/ hu/ it/ ja/ ko/ nl_NL/ pl/ pt/ pt_BR/ ro/ ru/ sk/ tr/ uk/ zh_CN/ [translate ] OK cp: cannot stat '[email protected]/schemas/gschemas.compiled': No such file or directory make: *** [Makefile:162: build] Error 1 ``` Now it works consistently: ``` ➜ make -j4 install [remove ] /home/brendan/.local/share/gnome-shell/extensions/[email protected] [gschemas ] OK [extension ] OK Reloading extensions does not work correctly and is no longer supported [reload ] OK [remove ] OK [translate ] ar/ ca/ cs/ de/ es_ES/ es_MX/ fa/ fi/ fr/ hu/ it/ ja/ ko/ nl_NL/ pl/ pt/ pt_BR/ ro/ ru/ sk/ tr/ uk/ zh_CN/ [translate ] OK [build ] OK [install ] /home/brendan/.local/share/gnome-shell/extensions/[email protected] Reloading extensions does not work correctly and is no longer supported [reload ] OK [install ] OK ```
|
LGTM. I don't know why the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #786.
I barely have any experience with Makefiles, but managed to figure this one out pretty quickly.
Previously, when using
-j4, it was showing an error on every second run:Now it works consistently: