Fix faulty error output on empty cache #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwtyler
reviewed
Nov 2, 2024
|
Ok, this works a little more gracefully and I was actually able to test it. Instead of relying on exit codes, we can just explicitly set a step output and not throw any errors. If we can validate everything, then skip authenticating, else continue to authenticate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's no existing cache, we skip the step with an
exit 1, but that also produces an error output for the step. Instead, this will exit gracefully (exit 0) by skipping the step and continuing to the next step to authenticate.fixes #29