Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for reset-password and new user creation support with Solid Security to compatibility layer #77

Open
2 tasks
jazzsequence opened this issue Jan 24, 2025 · 0 comments
Labels
compatibility layer Issues that relate to the compatibility layer component of the mu-plugin

Comments

@jazzsequence
Copy link
Contributor

see pantheon-systems/documentation#9388

Solid Security (formerly iThemes) has some additional tweaks that have been known internally in CSE but not surfaced to the Plugins With Known Issues docs page until recently. The issue derives from a URL query parameter being stripped on redirects that can potentially lock users out of their site. Solutions are in the PR.

The first step is adding a filter, which I believe can easily be done inside the mu-plugin's compatibility layer. The second step requires code to be added to wp-config.php. I think that this could be done elsewhere (e.g. inside a hook) and therefore inside the mu-plugin, but this needs to be tested.

The plugin is already listed as partially compatible in the plugin, so, while we could fix this one thing, we wouldn't be fixing everything. Additionally, while the partial compatibility is registered, there are no existing fixes for anything relating to this plugin -- the applied fix(es) would be new.

Done When

  • Solutions have been tested inside the mu-plugin
  • A new update of the mu-plugin is released

Notes

This is probably a fairly low-ish priority given that the plugin itself is already registered as "Partially Compatible", but applying the fix would be a boon to anyone using the plugin.

https://wordpress.org/plugins/better-wp-security/

@jazzsequence jazzsequence added the compatibility layer Issues that relate to the compatibility layer component of the mu-plugin label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility layer Issues that relate to the compatibility layer component of the mu-plugin
Projects
None yet
Development

No branches or pull requests

1 participant