Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Update Biome text after using Teleporting Hijinks #5173

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

ChrisLolz
Copy link

@ChrisLolz ChrisLolz commented Jan 24, 2025

What are the changes the user will see?

The biome text will display the correct biome after using the teleporting hijinks

Why am I making these changes?

Fixes #5152

What are the changes from a developer perspective?

Updated teleporting-hijinks-encounter.ts to call updateBiomeWaveText() after the biome transition has finished

Screenshots/Videos

hijink.mp4

How to test the changes?

Forced the mystery encounter in src/overrides.ts to test it

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@ChrisLolz ChrisLolz requested a review from a team as a code owner January 24, 2025 06:35
@ChrisLolz ChrisLolz marked this pull request as draft January 24, 2025 06:43
@ChrisLolz ChrisLolz marked this pull request as ready for review January 24, 2025 06:57
@Madmadness65 Madmadness65 added the P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Teleporting Hijinks does not Update Biome Text Immediately
2 participants