You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This can only be a warning because the actual semantics of opening a file cannot be known, but it's a possibility once I start analyzing the AST. I have a couple plans for that but don't see myself working on it any time soon.
1. Request
It would be nice, if package_reviewer will make an error, if function
open
don't haveencoding='utf-8'
.2. Justification
I use Cyrillic symbols. In some packages I get similar behavior.
I fix it, if I add
encoding='utf-8'
. Example:I change to
It fixed problem. I fix it in 4 Sublime Text packages:
Maybe we have it in other Sublime Text packages, hence I think, that it would be nice, if package_reviewer review it.
3. Desirable behavior
Package developer run package_reviewer → if
open
function doesn't haveencoding='utf-8'
, developer get error in terminal.Thanks.
The text was updated successfully, but these errors were encountered: