From 131b66a053df00499792dc6965295664815e6d29 Mon Sep 17 00:00:00 2001 From: Meghan Denny Date: Sat, 8 Feb 2025 01:21:19 -0800 Subject: [PATCH] update previously wrong messages --- test/js/node/child_process/child_process-node.test.js | 2 +- test/js/node/test/parallel/test-buffer-arraybuffer.js | 5 +++-- test/js/node/test/parallel/test-buffer-from.js | 3 ++- .../node/test/parallel/test-dgram-send-bad-arguments.js | 9 ++++++--- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/test/js/node/child_process/child_process-node.test.js b/test/js/node/child_process/child_process-node.test.js index c4ca225ebceb77..d0f03e23cbb811 100644 --- a/test/js/node/child_process/child_process-node.test.js +++ b/test/js/node/child_process/child_process-node.test.js @@ -657,7 +657,7 @@ describe("fork", () => { code: "ERR_INVALID_ARG_TYPE", name: "TypeError", message: expect.stringContaining( - `The "modulePath" argument must be of type string, Buffer, or URL. Received `, + `The "modulePath" argument must be of type string or an instance of Buffer or URL. Received `, ), }), ); diff --git a/test/js/node/test/parallel/test-buffer-arraybuffer.js b/test/js/node/test/parallel/test-buffer-arraybuffer.js index d721888d15f76d..6eef213faae259 100644 --- a/test/js/node/test/parallel/test-buffer-arraybuffer.js +++ b/test/js/node/test/parallel/test-buffer-arraybuffer.js @@ -43,8 +43,9 @@ assert.throws(function() { }, { code: 'ERR_INVALID_ARG_TYPE', name: 'TypeError', - message: 'The first argument must be of type string, Buffer, ArrayBuffer, Array, or Array-like Object.' + - ' Received an instance of AB' + message: 'The first argument must be of type string or an instance of ' + + 'Buffer, ArrayBuffer, Array, or Array-like Object. Received ' + + 'an instance of AB' }); // Test the byteOffset and length arguments diff --git a/test/js/node/test/parallel/test-buffer-from.js b/test/js/node/test/parallel/test-buffer-from.js index 7457f8d66a4433..c3bef347c27324 100644 --- a/test/js/node/test/parallel/test-buffer-from.js +++ b/test/js/node/test/parallel/test-buffer-from.js @@ -52,7 +52,8 @@ deepStrictEqual( const errObj = { code: 'ERR_INVALID_ARG_TYPE', name: 'TypeError', - message: 'The first argument must be of type string, Buffer, ArrayBuffer, Array, or Array-like Object.' + + message: 'The first argument must be of type string or an instance of ' + + 'Buffer, ArrayBuffer, Array, or Array-like Object.' + common.invalidArgTypeHelper(input) }; throws(() => Buffer.from(input), errObj); diff --git a/test/js/node/test/parallel/test-dgram-send-bad-arguments.js b/test/js/node/test/parallel/test-dgram-send-bad-arguments.js index 7257a0aca6a654..b30951d441cbd2 100644 --- a/test/js/node/test/parallel/test-dgram-send-bad-arguments.js +++ b/test/js/node/test/parallel/test-dgram-send-bad-arguments.js @@ -35,7 +35,8 @@ function checkArgs(connected) { { code: 'ERR_INVALID_ARG_TYPE', name: 'TypeError', - message: 'The "buffer" argument must be of type string, Buffer, TypedArray, or DataView. Received undefined' + message: 'The "buffer" argument must be of type string or an instance ' + + 'of Buffer, TypedArray, or DataView. Received undefined' } ); @@ -129,7 +130,8 @@ function checkArgs(connected) { { code: 'ERR_INVALID_ARG_TYPE', name: 'TypeError', - message: 'The "buffer" argument must be of type string, Buffer, TypedArray, or DataView. Received type number (23)' + message: 'The "buffer" argument must be of type string or an instance ' + + 'of Buffer, TypedArray, or DataView. Received type number (23)' } ); @@ -139,7 +141,8 @@ function checkArgs(connected) { { code: 'ERR_INVALID_ARG_TYPE', name: 'TypeError', - message: 'The "buffer list arguments" argument must be of type string, Buffer, TypedArray, or DataView. ' + + message: 'The "buffer list arguments" argument must be of type string ' + + 'or an instance of Buffer, TypedArray, or DataView. ' + 'Received an instance of Array' } );