Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when viewing site details page for a site with data contributed by an inactive school #609

Open
CarvellWakeman opened this issue Jan 2, 2018 · 2 comments
Open

Error when viewing site details page for a site with data contributed by an inactive school #609

CarvellWakeman opened this issue Jan 2, 2018 · 2 comments
Assignees
@CarvellWakeman @hertelc
Labels
bug low priority
Milestone
Production 1.1.0 ...

Comments

@CarvellWakeman
Copy link
Contributor

No description provided.

@CarvellWakeman CarvellWakeman self-assigned this Jan 2, 2018
@hertelc
Copy link
Collaborator

hertelc commented Jan 3, 2018

After some discussion, we will revisit this after the workshop is completed. The question is, if a school is deactivated, can users still login and add data even though that school is no longer active? Also, why wouldn't we keep showing the datasheets as by the school they were in instead of "No School Associated". The data is still good coming from that school. I think it should remain associated.

@hertelc
Copy link
Collaborator

hertelc commented Jan 3, 2018

We will keep the fix in place that Zach merged as it doesn't cause any harm and this is a corner case type issue that we can address later.

@hertelc hertelc added this to the Production 1.1.0 Release milestone Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarvellWakeman CarvellWakeman

@hertelc hertelc

Labels
bug low priority
Projects
None yet
Milestone
Production 1.1.0 Release
Development

No branches or pull requests
2 participants
@CarvellWakeman @hertelc