Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): corrctly combine schemas if type is array #1818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(core): corrctly combine schemas if type is array #1818

wants to merge 1 commit into from
+17 −4

Conversation

AllieJonsson
Copy link
Contributor

@AllieJonsson AllieJonsson commented Jan 13, 2025 •
edited
Loading

Status

READY

Description

Fixes #1817 as it was not properly fixed in #1739

Related PRs

List related PRs against other branches:

branch PR
fix/null-type #1739

@AllieJonsson AllieJonsson changed the title fix(core): combine schemas if type is array fix(core): corrctly combine schemas if type is array Jan 28, 2025
soartec-lab
soartec-lab reviewed Feb 1, 2025
View reviewed changes
Copy link
Member

@soartec-lab soartec-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AllieJonsson
Could you add a test?

@soartec-lab soartec-lab self-assigned this Feb 1, 2025
@AllieJonsson
Copy link
Contributor Author

@AllieJonsson Could you add a test?

Oops, seems like I forgot to do that. Ill fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soartec-lab soartec-lab soartec-lab left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@soartec-lab soartec-lab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nullable properties have additional | null declaration in OpenAPI 3.1
2 participants
@AllieJonsson @soartec-lab