Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to filter by ModalitiesInStudy when using a DB Backend that supports "ExtendedFind" #73

Open
sprog0 opened this issue Dec 23, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@sprog0
Copy link

sprog0 commented Dec 23, 2024

Orthanc and OE2 are today's mainline versions (2024-12-23)

If select one or more modalities in studies, but not all and push Search... No result found!
For example:
URL: /ui/app/#/filtered-studies?StudyDate=20241223&ModalitiesInStudy=XA&order-by=Metadata,LastUpdate,DESC
request to tools/find: {
"Level":"Study",
"Limit":500,
"Query":{"StudyDate":"20241223","ModalitiesInStudy":"XA"},
"RequestedTags":["ModalitiesInStudy","NumberOfStudyRelatedInstances","NumberOfStudyRelatedSeries","SOPClassesInStudy"],
"Expand":true
}
answer: {
"Details" : "Unable to use Limit or Since in tools/find when querying tags that are not stored as MainDicomTags in the Database",
"HttpError" : "Bad Request",
"HttpStatus" : 400,
"Message" : "Bad request",
"Method" : "POST",
"OrthancError" : "Bad request",
"OrthancStatus" : 8,
"Uri" : "/tools/find"
}

If remove Limit from request, answer will be the correct data.

Configuration:
"MaxStudiesDisplayed": 500,
"PageLoadSize": 50,
// "StudyListSearchMode": "search-as-you-type",
// "StudyListSearchAsYouTypeMinChars": 3,
// "StudyListSearchAsYouTypeDelay": 400,
// "StudyListContentIfNoSearch": "most-recents",
"StudyListSearchMode": "search-button",
"StudyListContentIfNoSearch": "empty",

@sprog0 sprog0 changed the title The search is lameing The search is lame Dec 23, 2024
@amazy amazy self-assigned this Dec 24, 2024
@amazy amazy added the bug Something isn't working label Dec 24, 2024
@amazy amazy changed the title The search is lame Unable to filter by ModalitiesInStudy when using a DB Backend that supports "ExtendedFind" Dec 24, 2024
@amazy
Copy link
Member

amazy commented Dec 24, 2024

Thanks for reporting the issue. I'll investigate after the holiday seasons ... and this will require quite some work ...

@amazy
Copy link
Member

amazy commented Dec 26, 2024

Prepared a test for the issue: https://orthanc.uclouvain.be/hg/orthanc-tests/rev/f3376bc9f514
Prepared some work in Orthanc: https://orthanc.uclouvain.be/hg/orthanc/rev/cc6027cbd8f1

Unfortunately, no easy fix -> to be continued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants