Add classification column to "Signals per Sources" table in project statistics popup #2819
Conversation
…ct statistics popup
PhilippMa
changed the base branch from
main
to
feat/move-criticality-display
| > | ||
| <span> | ||
| {licenseClassification | ||
| ? (classifications[licenseClassification] ?? '-') |
There was a problem hiding this comment.
please use UNKNOWN_SOURCE_PLACEHOLDER for this.
There was a problem hiding this comment.
I understand why you would want to use a text constant here, but since UNKNOWN_SOURCE_PLACEHOLDER has quite a specific name that doesn't really apply here, how about introducing a new text constant in text.ts and using it here instead?
There was a problem hiding this comment.
I also think that the titles of the extra columns (criticality and classification) have very similar (the same) style as sources columns, which is a bit misleading. Can we think about a way how to better separate them, e.g. by vertical line between license info columns and sources? or having a merged header cell "License info" with sub-columns Name, Criticality, Classification.
Summary of changes
Added a new column to the "Signals per Sources" table in the project statistics popup for displaying the classification of each license.
Context and reason for change
see #2804
How can the changes be tested
Check that classification information is shown correctly in the project statistics popup.
closes #2804