Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for extraManifests #26

Open
CiucurDaniel opened this issue Sep 11, 2024 · 3 comments
Open

Add support for extraManifests #26

CiucurDaniel opened this issue Sep 11, 2024 · 3 comments

Comments

@CiucurDaniel
Copy link
Contributor

CiucurDaniel commented Sep 11, 2024

Would it be possible to add a new value called extraManifests. As the name implies, it will provide means to deploy extra manifests as an array.

This is something which already exists in other charts such as the popular kube-prometheus-stack.

The use case for this is, for example, suppose you are using Istio on your cluster and you would like to be able to specify a Virtual Service definition to be deployed with the chart used for accessing your zipkin ui.

eg:

 # Extra manifests to deploy as an array
  extraManifests: 
    - apiVersion: networking.istio.io/v1beta1
      kind: VirtualService
      metadata:
        name: zipkin-vs
        namespace: zipkin
      spec:
        hosts:
        - "some-host.com"
        gateways:
        - some/gateway
        http:
        - match:
          - uri:
              prefix: "/zipkin"
          route:
          - destination:
              host: zipkin
              port:
                number: 9411

Implementation should be simple:

# templates/extra-objects.yaml

{{ range .Values.extraManifests }}
---
{{ tpl (toYaml .) $ }}
{{ end }}
@codefromthecrypt
Copy link
Member

would you be ok making this and a test in https://github.com/openzipkin/zipkin-helm/tree/master/charts/zipkin/ci?

@CiucurDaniel
Copy link
Contributor Author

Yes, I will try to submit a PR for this. (Excuse my late reply)

@CiucurDaniel
Copy link
Contributor Author

@codefromthecrypt done, submitted a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants