-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPS-DNS-Proxy not starting properly after reboot #25797
Comments
After device restart:
After restarting the service again:
What I've noticed are that some entries in dnsmasq seem to be missing. These entries for example only exist after I restart the service:
I think it might be the same issue #23469 faced back then... |
There may be an issue when no servers are defined for the dnsmasq instance. If you capture the output of |
Confirmed, got exactly the same issue. Just installed https-dns-proxy today. Could the reason be that dnsmasq starts before https-dns-proxy and fails to connect to it so defaults to DNS provided by the ISP? Can check the DNS setting by using a web service http://edns.ip-api.com/ |
Right after device reboot:
After manually restarting the service:
I think that @Shine- might be onto something openwrt/openwrt#17651 (comment) |
I don't understand why you have:
In your dhcp config when the service isn't running. It doesn't look like you've added those manually, it may be an artefact from the older version not cleaning up after itself. I'd recommend you stop the https-dns-proxy service, delete those entries if they persist and then start the https-dns-proxy service again. You may want to add some non-encrypted servers to your dhcp config first, after cleaning erroneous entries and starting the https-dns-proxy again. |
I don't understand either. I haven't added them and it can't be an artefact from an older version because it is a fresh OpenWrt installation, where I had to add this service again. I had this issue on the 24.10.0-rc4 and 24.10.0-rc3 release too... I am unsre but if I remember correctly I didn't have this issue on one of the older LuCI less snapshots of the device. |
I'll have to review the code, but if it's a fresh install it's definitely a bug most likely due to the fact that no servers are defined for dnsmasq instance before the proxy starts. |
I have the same problem on versions of routers xiaomi 4ac, 4c. Tested on both versions on both routers 23.05.5 and 24.10 rc5. |
I have these entries too, fresh https-dns-proxy install, never used it before. The lines also appear in /etc/config/dhcp file. |
Do you mean a static IP address from the ISP? I live in a student dorm and all rooms have a static IP assigned to them so maybe that's one of the reasons? |
This is a bug in this package, it is not about isp and router settings. The same problem on different isp (static and dhcp) |
He adds them himself 🤦♀️ https://github.com/stangri/https-dns-proxy/blob/db135baeca1a9fa263ff77c66dcd56ccd0a77e5d/files/etc/init.d/https-dns-proxy#L362 |
I just looked the entries up and it seems like you're right 😂 Now we just need to know why this default config gets loaded on every restart instead of our actual config ^_^ |
Can you walk me thru steps how you got from default install to your current setup? For the issue at hand -- can you try:
|
Sure!
That's basically it. After I restart the router my internet is gone again because the default config gets loaded with ISP banned DNS servers. Then I restart the service, which loads my DNS servers mentioned above and the internet works again. The question now is why the default stuff gets loaded on router restart... |
Describe the bug
After restarting the router the HTTPS-DNS-Proxy service does not start and work properly despite it being set to "Enabled".
It does show up as "Enabled" and the service appears to be running but the service does not actually work.
I have to manually press the button "Restart" to make it run.
It is not possible that this is a RAM issue because enough RAM is available.
Steps to reproduce
I've tried waiting up to half an hour after the restart because "maybe it just takes some time" but the only thing which actually makes it work is restarting the service manually - after which all blocked sites become accessible.
Actual behaviour
The service appears to be running in the U.I but is extremely buggy.
I have to manually restart the service after restarting the router because the service does not automatically start properly.
Stopping the service can lead to nothing happening and the U.I keep showing that it is running.
Expected behaviour
The service should start and work automatically after a router restart and route all DNS requests to the configured DNS servers and use DNS over HTTPS when the service is set as "Enabled".
The U.I should show th ecorrect status of the service.
Additional info
This is my device and formware:
This is a 64MB device but as shown in the screenshot enough RAM is available.
For me it is quite easy to check if it works or not because my ISP DNS blocks certain sites, which I cannot access without using DNS over HTTPS so I can just try to hit the site after a router restart and easily check it that way too.
I'm unsure if I am encountering the same issue like #23469 because it seems to be similar but in my case something gets loaded, just not the entire config.
During normal operation:
After a reboot:
Looks like something gets loaded but not the entire / my config.
After restarting the service it looks normal again:
Idk what to make of this. The op in #23469 did say he got nothing at all... meanwhile I do get something but not my entire valid config and I have to manually restart the service each time after reboot.
The text was updated successfully, but these errors were encountered: