Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After restoring a closed tab, the page's CSS styles are not loaded #5663

Open
deevroman opened this issue Feb 12, 2025 · 5 comments
Open

After restoring a closed tab, the page's CSS styles are not loaded #5663

deevroman opened this issue Feb 12, 2025 · 5 comments

Comments

@deevroman
Copy link
Contributor

deevroman commented Feb 12, 2025

How to reproduce the issue?

  1. Open https://openstreetmap.org/history
  2. Select any changeset
  3. Close the tab
  4. Wait a few seconds
  5. Restore the tab
  6. Styles are not loaded
2025-02-13.01.00.09.mp4

Firefox 136.0b4. I've also seen reports of a similar issue in Discord and the local community's Telegram chat, but I'm not sure if the steps are exactly the same.

It seems that the problem appeared today/yesterday.

@tomhughes
Copy link
Member

It would help if you provided a working URL instead of leaving us to guess a valid changeset...

@tomhughes
Copy link
Member

https://www.openstreetmap.org/changeset/162437268 looks like it was he changeset you used, and restoring the tab works fine for me in firefox.

It's hard so to see how what you describe can be anything other than a browser bug to be honest - if the browser can load it right the first time then it should be able to restore it and a restore is no different to an initial load as far as we are concerned.

@deevroman
Copy link
Contributor Author

deevroman commented Feb 12, 2025

Added the URL. But I think I missed an important step in the text (there is one in the video).

  1. Open https://openstreetmap.org/history
  2. Select any changeset
    and then also close the tab, wait and restore the tab.

If you open the changeset by URL, the tab is restored correctly. Probably the problem is how osm.org changes the browser history when switching from different URLs, in this case from /history -> /changeset/ID

@tomhughes
Copy link
Member

tomhughes commented Feb 13, 2025

Ah yes I can reproduce that. Unfortunately absolutely nobody understands that code...

@hlfan
Copy link
Contributor

hlfan commented Feb 13, 2025

It could be that we need to reintroduce the xhr query parameter and undo 8130b38 if that response is used for tab restoration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants