Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotating experimental data fails #1493

Closed
A-Artemis opened this issue Mar 4, 2024 · 5 comments
Closed

Rotating experimental data fails #1493

A-Artemis opened this issue Mar 4, 2024 · 5 comments
Assignees

Comments

@A-Artemis
Copy link

Steps to reproduce

  1. Open a .trc file by clicking File->Preview Experimental Data.
  2. Open the experimental data in the navigator to right click the .trc and click Transform...
  3. Rotate X by 90 degrees (I have tried Y and Z with angle [90, 180, 270, 360].
  4. Click on Save As... (I use the default name which is transformed_XXX.trc).
  5. Click on OK to close the dialogue box.
  6. Open the newly created transformed_XXX.trc file by clicking File->Preview Experimental Data.

Expected result

  • The transformed .trc is opened and can be seen in the Visualizer Window, and correctly rotated.

Actual result

  • The transformed data is not visible in VIsualizer Window. Below you can see both ExerimentalData_ in the Navigator but only 1 set of makers (this is from the original .trc) yet the markers of the new .trc are loaded. The floor and background is removed to see more of the environment.
    image

  • There is a chance that the saved transformed_XXX.trc is created but has 0 bytes.
    image

  • According to the documentation here it should be possible to view the rotation happen live with the use of the arrow keys, this does not work.

Environment and GUI version

  • OpenSim GUI version 4.5-2024-01-10-3b63585

  • Windows 11 x64

  • Data as a .txt so that it can be uploaded here. 35_34_mokka.txt

  • The data is taken from CMU Graphics Lab Motion Capture Database, subject 35 with motion 34. The .c3d data is downloaded and exported to a .trc with Mokka. This .trc is what I open in OpenSim.

  • I have had a lot of trouble using the CMU dataset with OpenSim (scaling and XYZ-framing issues). If there is a better workflow (in Python preferably) to handle experimental data then please let me know. My goal is to get the angles of each joint coordinate in the OpenSim model in a .csv, which can then be used for AI training. My current workflow is .c3d -> .trc -> Inverse Kinematics -> .mot -> .csv

@mrrezaie
Copy link

Hi, related to #1385 and #1344

@aymanhab
Copy link
Member

aymanhab commented May 22, 2024

Visualizer rotation should be fixed by #1507 will reassess after ci. I would not use the GUI for such workflow, and go for all python solution utilizing jupyter notebooks and opensim as described here
https://github.com/opensim-org/opensim-models/tree/master/notebooks
I'd be happy to help you set this up, and would be wonderful if you "donate" the resulting script to the community (logistics TBD)

@aymanhab
Copy link
Member

The issue was rotating data is fixed in these build artifacts @A-Artemis and @mrrezaie
https://github.com/opensim-org/opensim-gui/actions/runs/9198670131
While I couldn't reproduce the 0 size file, it's possible it's a downstream effect. Please check the artifacts and let me know.

@mrrezaie
Copy link

Hi @aymanhab, I tested the latest artifact and everything worked perfectly. Thanks for the fix.

@aymanhab
Copy link
Member

Awesome, thanks @mrrezaie for the quick turnaround 👍 and thanks @A-Artemis for reporting. Will merge after review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants