From c119609afb3bfd752b5f40ed3fe519488e9edb4d Mon Sep 17 00:00:00 2001 From: Ayman Habib Date: Mon, 23 May 2022 09:33:24 -0700 Subject: [PATCH 1/2] Tune CMake options for python per build instructions feedback on github --- CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 3396b00e35..e4c4903b1e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -160,6 +160,7 @@ mark_as_advanced(OPENSIM_PYTHON_STANDALONE) # Mainly for packagers; not users. option(OPENSIM_PYTHON_CONDA "Build specifically for Conda packaging which implies NO C++ tests and no runtime as managed by Conda." OFF) +mark_as_advanced(OPENSIM_PYTHON_CONDA) option(BUILD_API_ONLY "Build/install only headers, libraries, wrapping, tests; not applications (opensim, ik, rra, etc.)." OFF) @@ -549,6 +550,7 @@ endif() if(${BUILD_PYTHON_WRAPPING}) set(required_python_version 3) + set(Python3_ROOT_DIR "" CACHE PATH "Top level directory containing Python3 ") find_package(Python3 3.6 REQUIRED COMPONENTS Interpreter Development NumPy) message("Python3_FOUND:${Python3_FOUND}") message("Python3_VERSION:${Python3_VERSION}") From 2531bc471f5d63268214140a72fdcc47236c7573 Mon Sep 17 00:00:00 2001 From: Ayman Habib Date: Mon, 23 May 2022 11:31:25 -0700 Subject: [PATCH 2/2] Update CMakeLists.txt Expand cmake comment per feedback on PR --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index e4c4903b1e..f8bd4ef10b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -550,7 +550,7 @@ endif() if(${BUILD_PYTHON_WRAPPING}) set(required_python_version 3) - set(Python3_ROOT_DIR "" CACHE PATH "Top level directory containing Python3 ") + set(Python3_ROOT_DIR "" CACHE PATH "Top level directory containing Python3. For conda environments, this can also be set to the top level directory for a specific environment.") find_package(Python3 3.6 REQUIRED COMPONENTS Interpreter Development NumPy) message("Python3_FOUND:${Python3_FOUND}") message("Python3_VERSION:${Python3_VERSION}")