Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform Awareness / Option #25

Open
puerco opened this issue Nov 15, 2022 · 3 comments
Open

Platform Awareness / Option #25

puerco opened this issue Nov 15, 2022 · 3 comments

Comments

@puerco
Copy link
Member

puerco commented Nov 15, 2022

When analyzing the dependencies of projects, the effective dependencies can change based on what platform the build is targeting. In order to cover those cases, we need to be able to do two things from any of the parsers:

  1. Give the parsers a unified way of knowing which platform they are running on and
  2. Create an option to specify the target platform so that each parser can pass a platform slug to the underlying tooling
@nishakm
Copy link
Contributor

nishakm commented Nov 15, 2022

Does this need to be templated so those contributing parsers can follow a set pattern?

@puerco
Copy link
Member Author

puerco commented Nov 15, 2022

I'm thinking on adding an options mechanism to the parsers once they are stable. To detect the platform I will add a help function somewhere that they can reuse to get the info.

@ba11b0y
Copy link
Contributor

ba11b0y commented Mar 6, 2023

What if we add

  • A function SetPlatform and a field Platform to the Plugin interface
  • Once Platform is set, the parser can read and pass the same to the underlying tooling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants