[RFC] Abstract the target endianness with a macro #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only a few changes are needed to swap the target instruction endianness. Most of these places are already conditional on the host endianness, but the changes are not completely overlapping. Add a macro for the target endianness so it can be swapped out. In the future, this choice could come from the config file, but that requires more refactoring. Signed-off-by: Samuel Holland <[email protected]>
stffrdhrn
reviewed
Jun 21, 2022
| @@ -64,7 +64,12 @@ | |||
| #endif /* ULONGEST */ | |||
|
|
|||
| /* Endianness convenience macros */ | |||
| #define TARGET_BIG_ENDIAN | |||
There was a problem hiding this comment.
To switch this to little endian you just remove this line? I think just adding a comment explaining the purpose of the TARGET_BIG_ENDIAN macro should be good enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to running code on the AR100 in little-endian mode, this is how I tested my little-endian toolchain patches. I'm not sure if this is worth merging in its current state, but at least it documents what parts of the code would need to be changed.
Only a few changes are needed to swap the target instruction endianness.
Most of these places are already conditional on the host endianness, but
the changes are not completely overlapping. Add a macro for the target
endianness so it can be swapped out.
In the future, this choice could come from the config file, but that
requires more refactoring.
Signed-off-by: Samuel Holland [email protected]