From 85818a9d8a1dd11541fa9d0d7eaabaf3d248e83f Mon Sep 17 00:00:00 2001 From: ahacart-adexos <48205019+ahacart-adexos@users.noreply.github.com> Date: Tue, 16 Aug 2022 20:34:08 +0200 Subject: [PATCH] Fix type to avoid type error due to strict type --- Handler/RotatingFileHandler.php | 2 +- Handler/SlackHandler.php | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Handler/RotatingFileHandler.php b/Handler/RotatingFileHandler.php index 7a8ad8e..4e2ae17 100644 --- a/Handler/RotatingFileHandler.php +++ b/Handler/RotatingFileHandler.php @@ -72,7 +72,7 @@ public function getInstance(): HandlerInterface $this->directoryList->getPath(DirectoryList::VAR_DIR), $this->scopeConfig->getValue($this->filenamePath) ), - $this->scopeConfig->getValue($this->maxFilesPath), + (int) $this->scopeConfig->getValue($this->maxFilesPath), $this->scopeConfig->getValue($this->levelPath) ); } diff --git a/Handler/SlackHandler.php b/Handler/SlackHandler.php index 871ba03..81e67c0 100644 --- a/Handler/SlackHandler.php +++ b/Handler/SlackHandler.php @@ -105,12 +105,12 @@ public function getInstance(): HandlerInterface $this->scopeConfig->getValue($this->tokenPath), $this->scopeConfig->getValue($this->channelPath), $this->scopeConfig->getValue($this->usernamePath), - $this->scopeConfig->getValue($this->useAttachmentPath), + $this->scopeConfig->isSetFlag($this->useAttachmentPath), $this->scopeConfig->getValue($this->iconEmojiPath), $this->scopeConfig->getValue($this->levelPath), - $this->scopeConfig->getValue($this->bubblePath), - $this->scopeConfig->getValue($this->useShortAttachmentPath), - $this->scopeConfig->getValue($this->includeContextAndExtraPath) + $this->scopeConfig->isSetFlag($this->bubblePath), + $this->scopeConfig->isSetFlag($this->useShortAttachmentPath), + $this->scopeConfig->isSetFlag($this->includeContextAndExtraPath) ); }