Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 3rd party images #5681

Open
svrnm opened this issue Nov 25, 2024 · 4 comments
Open

Enable 3rd party images #5681

svrnm opened this issue Nov 25, 2024 · 4 comments

Comments

@svrnm
Copy link
Member

svrnm commented Nov 25, 2024

For #5462 we want to use a 3rd party image. This image has a MIT license, so it is compatible with our project. We need to make sure that it is attributed correctly.

The CNCF provides these recommendations for attribution notices. I would argue that an image is a "vendored component", since we want to incorporate it unmodified.

So, based on that, I suggest we do the following:

  • We create a folder for 3rd party images (or assets), e.g. under assets/third_party
  • We add a README.md to that folder calling out it's purpose
  • We create a folder for each 3rd party asset (here something like iconduck-image-not-found)
  • We put the file + the license into the folder
  • We can use it.
  • We update our top level README.md Licenses section to call this out

I understand that this sounds like a lot of effort for adding a single image, but I argue that this is going to be helpful in the future as well, since

  1. it enables us to use other images following this pattern as well
  2. we might need this if we want to add company logos to ecosystem pages like vendors, adopters, etc.
@tiffany76
Copy link
Contributor

This proposal makes sense to me. I say we go ahead.

@theletterf
Copy link
Member

Agree with the proposal!

@chalin
Copy link
Contributor

chalin commented Dec 4, 2024

Thanks for looking into this and your proposal. First thought: yes, it sounds like a lot of work, and I'd push back on it for as long as we can reasonably avoid it.

Stepping back a bit regarding the original PR: have we considered using just a Font Awesome icon instead, or a completely-free-and-no-license-hassle stock image source?

@svrnm
Copy link
Member Author

svrnm commented Dec 5, 2024

Thanks for looking into this and your proposal. First thought: yes, it sounds like a lot of work, and I'd push back on it for as long as we can reasonably avoid it.

Stepping back a bit regarding the original PR: have we considered using just a Font Awesome icon instead, or a completely-free-and-no-license-hassle stock image source?

the font awesome icons might be too small/minimalistic, I like the idea of the image, of course someone with a telescope not finding what they are looking for would be my preferred image. We could also use a variant of

https://opentelemetry.io/homepage-hero-as-background_hu13043826424429285166.jpg

but let me move that over into the original PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

4 participants