-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable 3rd party images #5681
Comments
This proposal makes sense to me. I say we go ahead. |
Agree with the proposal! |
Thanks for looking into this and your proposal. First thought: yes, it sounds like a lot of work, and I'd push back on it for as long as we can reasonably avoid it. Stepping back a bit regarding the original PR: have we considered using just a Font Awesome icon instead, or a completely-free-and-no-license-hassle stock image source? |
the font awesome icons might be too small/minimalistic, I like the idea of the image, of course someone with a telescope not finding what they are looking for would be my preferred image. We could also use a variant of https://opentelemetry.io/homepage-hero-as-background_hu13043826424429285166.jpg but let me move that over into the original PR |
For #5462 we want to use a 3rd party image. This image has a MIT license, so it is compatible with our project. We need to make sure that it is attributed correctly.
The CNCF provides these recommendations for attribution notices. I would argue that an image is a "vendored component", since we want to incorporate it unmodified.
So, based on that, I suggest we do the following:
assets/third_party
iconduck-image-not-found
)I understand that this sounds like a lot of effort for adding a single image, but I argue that this is going to be helpful in the future as well, since
The text was updated successfully, but these errors were encountered: