Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] fix serialization/deserialization for u64 and "NaN" float fields in Metrics #2491

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[WIP] fix serialization/deserialization for u64 and "NaN" float fields in Metrics #2491

wants to merge 8 commits into from
+218 −5

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jan 1, 2025 •
edited
Loading

Fixes #2487
Design discussion issue (if applicable) #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner January 1, 2025 18:10
@lalitb lalitb marked this pull request as draft January 1, 2025 18:10
@codecov Codecov
Copy link

codecov bot commented Jan 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (a1dda22) to head (c64d3b3).

Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #2491   +/-   ##
=====================================
  Coverage   77.9%   77.9%           
=====================================
  Files        123     123           
  Lines      22888   22888           
=====================================
  Hits       17839   17839           
  Misses      5049    5049

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb lalitb added the integration tests Run integration tests label Jan 2, 2025
@lalitb lalitb mentioned this pull request Jan 3, 2025
Open
@lalitb lalitb marked this pull request as ready for review January 7, 2025 09:57
@lalitb lalitb changed the title [WIP] fix serialization/deserialization for u64 type fields in Metrics [WIP] fix serialization/deserialization for u64 and float type fields in Metrics Jan 7, 2025
@lalitb lalitb changed the title [WIP] fix serialization/deserialization for u64 and float type fields in Metrics [WIP] fix serialization/deserialization for u64 and "NaN" float fields in Metrics Jan 7, 2025
@lalitb
Copy link
Member Author

lalitb commented Jan 7, 2025

@nikhilsinhaparseable would it be possible for you to validate and confirm this PR against the issues mentioned in #2487 - It would be easy to get it merged in that case. Else, I will try adding unit-tests sometime next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
integration tests Run integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serialization Fails for u64 Fields Due to Incoming String Values in OpenTelemetry Metrics
1 participant
@lalitb