Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: opentelemetry_allocator_targets_remaining should be a gauge #3590

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: opentelemetry_allocator_targets_remaining should be a gauge #3590

wants to merge 1 commit into from

Conversation

chenlujjj
Copy link

Description:

Link to tracking Issue(s):

Testing:

Documentation:

@chenlujjj chenlujjj requested a review from a team as a code owner January 2, 2025 15:14
@swiatekm
Copy link
Contributor

swiatekm commented Jan 2, 2025

Could you add a changelog entry? Running make chlog-new in the project root will give you a template. In my opinion, this should be marked as a breaking change.

@chenlujjj chenlujjj force-pushed the fix-allocator-metric branch from 3f1608b to 3e3ff40 Compare January 2, 2025 15:57
@chenlujjj
Copy link
Author

Thanks for reminding. Added the change log.

@swiatekm
Copy link
Contributor

swiatekm commented Jan 2, 2025

Thank you for the contribution!

@chenlujjj chenlujjj force-pushed the fix-allocator-metric branch from 3e3ff40 to 874e21a Compare January 3, 2025 02:09
@swiatekm swiatekm requested a review from a team January 3, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why metric "opentelemetry_allocator_targets_remaining" is a counter instead of a gauge ?
2 participants
@chenlujjj @swiatekm