-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ExtendedTextMapGetter in instrumentations #12868
Comments
I have gone through all the instrumentations and found that the following 15
|
Would this contribution be welcome? |
hi @xiepuhuan! yes, let's start with just one (pick any), so we can work through any issues/concerns, and then you could do the rest in a single follow-up PR if you'd like to continue |
Thank you for your reply. I will try to complete the first pull request for |
Is your feature request related to a problem? Please describe.
Spec has recently changed to specify extraction of multiple values for a given key: open-telemetry/opentelemetry-specification#4295
The Java SDK has added
ExtendedTextMapGetter
to handle this: open-telemetry/opentelemetry-java#6852 (when stabilised this extension may become a default method onTextMapGetter
which should be then implemented by instrumentations).Describe the solution you'd like
For instrumentations that have carriers that support multiple values for a single key (most HTTP implementations) this should be a relatively straightforward change.
It does not necessarily need to be supported by all instrumentations.
The text was updated successfully, but these errors were encountered: