Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency conflict #6555

Closed
XiaoWeiKIN opened this issue Jan 6, 2025 · 5 comments
Closed

Dependency conflict #6555

XiaoWeiKIN opened this issue Jan 6, 2025 · 5 comments
Labels
bug Something isn't working sampler: jaegerremote

Comments

@XiaoWeiKIN
Copy link

When used at the same time go.opentelemetry.io/contrib/samplers/jaegerremote andgithub.com/jaegertracing/jaeger will be dependent on conflict, because they were performed the init func.

func init() {
	proto.RegisterEnum("jaeger.api_v2.SamplingStrategyType", SamplingStrategyType_name, SamplingStrategyType_value)
	proto.RegisterType((*ProbabilisticSamplingStrategy)(nil), "jaeger.api_v2.ProbabilisticSamplingStrategy")
	proto.RegisterType((*RateLimitingSamplingStrategy)(nil), "jaeger.api_v2.RateLimitingSamplingStrategy")
	proto.RegisterType((*OperationSamplingStrategy)(nil), "jaeger.api_v2.OperationSamplingStrategy")
	proto.RegisterType((*PerOperationSamplingStrategies)(nil), "jaeger.api_v2.PerOperationSamplingStrategies")
	proto.RegisterType((*SamplingStrategyResponse)(nil), "jaeger.api_v2.SamplingStrategyResponse")
	proto.RegisterType((*SamplingStrategyParameters)(nil), "jaeger.api_v2.SamplingStrategyParameters")
}
@XiaoWeiKIN XiaoWeiKIN added bug Something isn't working sampler: jaegerremote labels Jan 6, 2025
@dmathieu
Copy link
Member

dmathieu commented Jan 6, 2025

cc @yurishkuro as code owner.

@yurishkuro
Copy link
Member

I don't understand the problem. go.opentelemetry.io/contrib/samplers/jaegerremote is an SDK library. Under what conditions does it conflict with github.com/jaegertracing/jaeger, which is Jaeger backend code?

@XiaoWeiKIN
Copy link
Author

@yurishkuro May have a look #2981, when I use the jaeger-receiver as the receiver will appear this problem

@yurishkuro
Copy link
Member

@XiaoWeiKIN thanks. I opened jaegertracing/jaeger#6494 as a possible solution. But this ticket looks like exact duplicate of #2981, I recommend closing it.

@XiaoWeiKIN
Copy link
Author

@yurishkuro ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sampler: jaegerremote
Projects
None yet
Development

No branches or pull requests

4 participants
@dmathieu @yurishkuro @XiaoWeiKIN and others