Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentation.AWS]: always add context propagation data to requests #2447

Merged
merged 9 commits into from
Jan 8, 2025
Merged

[Instrumentation.AWS]: always add context propagation data to requests #2447

merged 9 commits into from
Jan 8, 2025
+96 −17

Conversation

cfbao
Copy link
Contributor

@cfbao cfbao commented Dec 25, 2024 •
edited
Loading

Fixes #2345

Changes

Move code that adds context propagation data to requests into a dedicated method AddPropagationDataToRequest, and always run that regardless of sampling decision.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 25, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS label Dec 25, 2024
@cfbao
Copy link
Contributor Author

cfbao commented Dec 25, 2024

There's no existing unit tests in this area, but I've verified that correctly adds relevant message attribute to SQS requests using the script showed in #2345.

@cfbao cfbao marked this pull request as ready for review December 25, 2024 03:16
@cfbao cfbao requested a review from a team as a code owner December 25, 2024 03:16
ppittle
ppittle reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@ppittle ppittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cfbao - Thank you for the contribution!

There's no existing unit tests in this area, but I've verified that correctly adds relevant message attribute to SQS requests using the script showed in #2345.

Would it be possible to add some unit test coverage around this feature?

Otherwise, this looks good to me.

@cfbao
Copy link
Contributor Author

cfbao commented Jan 1, 2025

@ppittle Oh I missed what these instrumentation tests were doing.
Added coverage on SQS message attributes for both sampled and not sampled requests now.

@cfbao
Copy link
Contributor Author

cfbao commented Jan 6, 2025 •
edited
Loading

Fixed markdownlint issue.

This test failure seems unrelated to this change though:
https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/12579606871/job/35060088493#step:7:72
or at least I'm not able to repro locally.

Kielek
Kielek approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging based on @ppittle decision.

@Kielek Kielek merged commit 5512176 into open-telemetry:main Jan 8, 2025
61 checks passed
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (71655ce) to head (430d9ed).
Report is 678 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #2447       +/-   ##
==========================================
- Coverage   73.91%       0   -73.92%     
==========================================
  Files         267       0      -267     
  Lines        9615       0     -9615     
==========================================
- Hits         7107       0     -7107     
+ Misses       2508       0     -2508

see 263 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kielek Kielek Kielek approved these changes

@ppittle ppittle ppittle approved these changes

@muhammad-othman muhammad-othman Awaiting requested review from muhammad-othman

@srprash srprash Awaiting requested review from srprash

Assignees

@ppittle ppittle

@muhammad-othman muhammad-othman

@srprash srprash

Labels
comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] AWS instrumentation not adding request specific info on requests *not* sampled
5 participants
@cfbao @ppittle @Kielek @muhammad-othman @srprash