Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate logziospan dependency on the plugin/storage/es/spanstore/dbmodel #36970

Closed
zzzk1 opened this issue Dec 27, 2024 · 2 comments · Fixed by #36972
Closed

Eliminate logziospan dependency on the plugin/storage/es/spanstore/dbmodel #36970

zzzk1 opened this issue Dec 27, 2024 · 2 comments · Fixed by #36972
Labels
exporter/logzio

Comments

@zzzk1
Copy link
Contributor

zzzk1 commented Dec 27, 2024

Component(s)

exporter/logzio

Describe the issue you're reporting

To prevent circular dependencies between Jaeger and contrib, copy the necessary code and replace the import.
here:jaegertracing/jaeger#6410
@zzzk1 zzzk1 added the needs triage New item requiring triage label Dec 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@zzzk1 zzzk1 mentioned this issue Dec 27, 2024
Merged
@github-actions github-actions bot mentioned this issue Dec 31, 2024
Closed
@crobert-1
Copy link
Member

Removing needs triage as a code owner as approved the PR that implements this change.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Jan 6, 2025
AkhigbeEromo pushed a commit to sematext/opentelemetry-collector-contrib that referenced this issue Jan 13, 2025
@zzzk1 @AkhigbeEromo
[logzioexporter] Remove dependency on jaeger dbmodel (open-telemetry#…
449ecf7 
…36972)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Copy the Jaeger plugin/storage/es/spanstore/dbmodel for logzioexporter,
and remove the dependency. The dbmodel package in Jaeger will be
internal from v1.65 (jaegertracing/jaeger#6428).

<!-- Issue number (e.g. open-telemetry#36970) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#36970

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Covered by existing
<!--Describe the documentation added.-->

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exporter/logzio
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[logzioexporter] Remove dependency on jaeger dbmodel zzzk1/opentelemetry-collector-contrib
2 participants
@zzzk1 @crobert-1