From 4691b5d292dd62e978947d7a11e01584cb7ba692 Mon Sep 17 00:00:00 2001 From: SumanMaharana Date: Mon, 10 Feb 2025 17:59:15 +0530 Subject: [PATCH] Fix powerbi test connection sucess with bad credentials --- .../source/dashboard/powerbi/client.py | 21 +++++++------------ 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/ingestion/src/metadata/ingestion/source/dashboard/powerbi/client.py b/ingestion/src/metadata/ingestion/source/dashboard/powerbi/client.py index 381094e18010..c9a38236f5fc 100644 --- a/ingestion/src/metadata/ingestion/source/dashboard/powerbi/client.py +++ b/ingestion/src/metadata/ingestion/source/dashboard/powerbi/client.py @@ -94,7 +94,7 @@ def get_auth_token(self) -> Tuple[str, str]: auth_response = PowerBiToken(**response_data) if not auth_response.access_token: raise InvalidSourceException( - "Failed to generate the PowerBi access token. Please check provided config" + f"Failed to generate the PowerBi access token. Please check provided config {response_data}" ) logger.info("PowerBi Access Token generated successfully") @@ -105,19 +105,12 @@ def fetch_dashboards(self) -> Optional[List[PowerBIDashboard]]: Returns: List[PowerBIDashboard] """ - try: - if self.config.useAdminApis: - response_data = self.client.get("/myorg/admin/dashboards") - response = DashboardsResponse(**response_data) - return response.value - group = self.fetch_all_workspaces()[0] - return self.fetch_all_org_dashboards(group_id=group.id) - - except Exception as exc: # pylint: disable=broad-except - logger.debug(traceback.format_exc()) - logger.warning(f"Error fetching dashboards: {exc}") - - return None + if self.config.useAdminApis: + response_data = self.client.get("/myorg/admin/dashboards") + response = DashboardsResponse(**response_data) + return response.value + group = self.fetch_all_workspaces()[0] + return self.fetch_all_org_dashboards(group_id=group.id) def fetch_all_org_dashboards( self, group_id: str