Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Alert/Notification Publisher config object may be modified externally via object aliasing #19496

Open
dechoma opened this issue Jan 23, 2025 · 0 comments · May be fixed by #19495
Open

BUG: Alert/Notification Publisher config object may be modified externally via object aliasing #19496

dechoma opened this issue Jan 23, 2025 · 0 comments · May be fixed by #19495

Comments

@dechoma
Copy link
Contributor

dechoma commented Jan 23, 2025 •
edited
Loading

Affected module
backend

Describe the bug
Publisher config objects may be modified externally via object aliasing. This can lead to unintended side effects

line receiverList = action.getReceivers() == null ? receiverList : action.getReceivers(); is linking receiverList variable with internal action.receivers Set

To Reproduce

Trigger Email notifications to followers,
during second and subsequent triggers, action.getReceivers() will contain receivers from previous runs

Expected behavior
action.getReceivers()should be idempotent

Version:

  • OpenMetadata version: [1.5.11]

Additional context
Add any other context about the problem here.
@dechoma dechoma linked a pull request Jan 23, 2025 that will close this issue
Open
9 tasks
@dechoma dechoma changed the title BUG: Alert/Notification Publisher config objects may be modified externally via object aliasing BUG: Alert/Notification Publisher config object may be modified externally via object aliasing Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove object aliasing from buildReceiversListFromActions dechoma/OpenMetadata
1 participant
@dechoma