feat: add doc gen, move schema path, add tests, fix react gen #68
Conversation
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
changed the title
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "$id": "https://raw.githubusercontent.com/open-feature/cli/refs/heads/main/schema/v0/flag_manifest.json", | |||
There was a problem hiding this comment.
I'm not sure if we need/want and ID. FYI @toddbaert
| @@ -2,27 +2,27 @@ | |||
| "flags": { | |||
| "enableFeatureA": { | |||
| "flagType": "boolean", | |||
| "defaultValue": false, | |||
| "codeDefault": false, | |||
There was a problem hiding this comment.
I think we should revert this.
I understand why you'd change it, defaultValue seems a bit confusing right next to defaultVariant (in flagd, for example) but I think that's just because there's a bit of a conceptual hurdle around "code default" vs "no targeting matched fallthrough" anyway, and that hurdle is somewhat inevitable and can only be address with good descriptions, docs and education.
"defaultValue" is what this parameter is called in code, and I think for consistency we should use that here, or we risk even more confusion.
There was a problem hiding this comment.
Okay, good point. I've reverted this change. Please re-review when you have a moment.
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
changed the title
Signed-off-by: Michael Beemer <[email protected]>
This PR
Rename default valueRelated Issues
Fixes #66, #60
Notes
It's a big PR that I could break into smaller changes if necessary.