Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Replace FluentAssertions by AwesomeAssertions #88

Open
CesarD opened this issue Feb 9, 2025 · 3 comments
Open

FEATURE: Replace FluentAssertions by AwesomeAssertions #88

CesarD opened this issue Feb 9, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@CesarD
Copy link
Collaborator

CesarD commented Feb 9, 2025

Detailed Description

Replace existing dependency FluentAssertions by a fork of it: AwesomeAssertions.

Context

Due to the changes in licensing introduced in the current dependency FluentAssertions (fluentassertions/fluentassertions#2943), it becomes necessary to replace this dependency by another one that fits in the OSS model without incurring into additional licensing charges to users of Monaco.

Possible Implementation

AwesomeAssertions is a good candidate since it's a fork of the original FluentAssertions and it would provoke the less impact in the current code base, making the switch smoother without requiring any significant changes or having to re-learn any new API from a new library.

@CesarD CesarD added the enhancement New feature or request label Feb 9, 2025
@matthewtoghill
Copy link
Collaborator

It's worth noting that it's possible to stay on v7 indefinitely. Replacing may or may not be necessary long term and it could be a good idea to see how well AwesomeAssertions is maintained or whether it gets abandoned.

@CesarD
Copy link
Collaborator Author

CesarD commented Feb 13, 2025

Indeed we could, but I'd rather leave it for good in case someone using Monaco ends up upgrading accidentally into v8 after generating their own projects. I prefer to go into AwesomeAssertions just for the sake of keeping the same API and avoid any "illegal" upgrade, than staying in FA and someone getting into trouble because of it. Besides, FA was already pretty much feature complete... It's not like AwesomeAssertions will have much room for improvement anyway... What do you think?

@matthewtoghill
Copy link
Collaborator

Yea on reflection I agree, it's better to avoid leaving it open for future projects to upgrade into FA v8+ and hit the licensing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants