Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array and LAPACK features on MacOS and Windows. #1

Open
olson-sean-k opened this issue May 30, 2019 · 1 comment
Open

Support array and LAPACK features on MacOS and Windows. #1

olson-sean-k opened this issue May 30, 2019 · 1 comment

Comments

@olson-sean-k
Copy link
Owner

olson-sean-k commented May 30, 2019

The array feature uses ndarray and supporting crates to implement operations that require solving linear systems of arbitrary size. This allows Theon to optionally support certain useful spatial queries, such as computing a best-fit plane given a sampling of points.

This depends on ndarray-linalg, which builds and links BLAS/LAPACK libraries. These require building source packages and don't offer consistent support for different OSes. In the worst case, the output on different OSes differs (which is very likely a bug). 😬 Currently, this feature is gated behind cfg(target_os = "linux").

Only supporting certain OSes means that downstream code must always use conditional compilation. If possible, find some combination of packages that build and run on Linux, MacOS, and Windows.

@olson-sean-k olson-sean-k changed the title Support array and LAPACK features on Linux, MacOS, and Windows. Support array and LAPACK features on MacOS and Windows. May 31, 2019
@olson-sean-k
Copy link
Owner Author

As mentioned in #9, the different output on different OSes is probably due to bad tests. The determined plane test uses collinear points!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant