Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing for authenticaion #23

Open
mdavids opened this issue Nov 10, 2020 · 1 comment
Open

Consider allowing for authenticaion #23

mdavids opened this issue Nov 10, 2020 · 1 comment
Assignees
Labels
feature request New features to add to dog
Milestone

Comments

@mdavids
Copy link

mdavids commented Nov 10, 2020

Maybe something like:

./dog -H @https://doh:[email protected]/dns-query example.nl

Albeit this method is deprecated as per RFC3986, par. 3.2.1, so perhaps "-u doh -p BeGentle" would be the better approach.

@ogham
Copy link
Owner

ogham commented Nov 11, 2020

I did consider this, but didn't think there'd be any DoH servers that required authentication. Of course, over time, I guess there would be.

My preference would actually be to embed the credentials in the URL, even though doing that is deprecated, as you say. Providing a username and password is only appropriate for the HTTPS transport, where you have to pass a URL anyway, and they'll be by far the less-used option compared to not providing any, so I'd rather avoid adding two whole new top-level command-line arguments for this case. At some point, dog will switch to the url crate for URL parsing, so we'll essentially get this functionality "for free" in a way.

(I suppose we'd also have to handle HTTP 401 with a friendlier error message when implementing this).

@ogham ogham self-assigned this Mar 28, 2021
@ogham ogham added the feature request New features to add to dog label Mar 28, 2021
@ogham ogham added this to the v0.3.0 milestone Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New features to add to dog
Projects
None yet
Development

No branches or pull requests

2 participants