-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] tls (6 packages) (2.0.0) #27389
Conversation
CHANGES: * Use dune variants (mirage-ptime) instead of functorising over PCLOCK (mirleft/ocaml-tls#513 @hannesm)
CI looks fine, I'm not sure what to do about irmin-cli and mdx not finding mirage-ptime (a dune variant). may be best to add some upper bound constraints for irmin-cli... |
Which bound should we add? Can you send a separate PR? Otherwise I can do it later if you point me in the right direction There is a test failure on ocaml 4.13:
|
``` == ERROR while compiling tls.2.0.0 ==========================================# context 2.4.0~alpha1~dev | linux/x86_64 | ocaml-base-compiler.4.13.1 | pinned(https://github.com/mirleft/ocaml-tls/releases/download/v2.0.0/tls-2.0.0.tbz) path ~/.opam/4.13/.opam-switch/build/tls.2.0.0 command ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p tls -j 71 exit-code 1 env-file ~/.opam/log/tls-7-ff13e6.env output-file ~/.opam/log/tls-7-ff13e6.out = output ### (cd _build/default && /home/opam/.opam/4.13/bin/ocamlc.opt -w -40 -g -bin-annot -I tests/.testlib.objs/byte -I /home/opam/.opam/4.13/lib/asn1-combinators -I /home/opam/.opam/4.13/lib/base64 -I /home/opam/.opam/4.13/lib/digestif -I /home/opam/.opam/4.13/lib/domain-name -I /home/opam/.opam/4.13/lib/eqaf -I /home/opam/.opam/4.13/lib/fmt -I /home/opam/.opam/4.13/lib/gmap -I /home/opam/.opam/4.13/lib/ipaddr -I /home/opam/.opam/4.13/lib/kdf/hkdf -I /home/opam/.opam/4.13/lib/kdf/pbkdf -I /home/opam/.opam/4.13/lib/logs -I /home/opam/.opam/4.13/lib/macaddr -I /home/opam/.opam/4.13/lib/mirage-crypto -I /home/opam/.opam/4.13/lib/mirage-crypto-ec -I /home/opam/.opam/4.13/lib/mirage-crypto-pk -I /home/opam/.opam/4.13/lib/mirage-crypto-rng -I /home/opam/.opam/4.13/lib/mirage-crypto-rng/unix -I /home/opam/.opam/4.13/lib/ohex -I /home/opam/.opam/4.13/lib/ounit2 -I /home/opam/.opam/4.13/lib/ounit2/advanced -I /home/opam/.opam/4.13/lib/ptime -I /home/opam/.opam/4.13/lib/seq -I /home/opam/.opam/4.13/lib/stdlib-shims -I /home/opam/.opam/4.13/lib/x509 -I /home/opam/.opam/4.13/lib/zarith -I lib/.tls.objs/byte -no-alias-deps -o tests/.testlib.objs/byte/testlib.cmo -c -impl tests/testlib.ml) File "tests/testlib.ml", line 3, characters 9-43: 3 | let () = Mirage_crypto_rng_unix.use_default () ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Error: Unbound value Mirage_crypto_rng_unix.use_default (cd _build/default && /home/opam/.opam/4.13/bin/ocamlopt.opt -w -40 -g -I tests/.key_derivation.eobjs/byte -I tests/.key_derivation.eobjs/native -I /home/opam/.opam/4.13/lib/alcotest -I /home/opam/.opam/4.13/lib/alcotest/engine -I /home/opam/.opam/4.13/lib/alcotest/stdlib_ext -I /home/opam/.opam/4.13/lib/asn1-combinators -I /home/opam/.opam/4.13/lib/astring -I /home/opam/.opam/4.13/lib/base64 -I /home/opam/.opam/4.13/lib/cmdliner -I /home/opam/.opam/4.13/lib/digestif/c -I /home/opam/.opam/4.13/lib/domain-name -I /home/opam/.opam/4.13/lib/eqaf -I /home/opam/.opam/4.13/lib/fmt -I /home/opam/.opam/4.13/lib/gmap -I /home/opam/.opam/4.13/lib/ipaddr -I /home/opam/.opam/4.13/lib/kdf/hkdf -I /home/opam/.opam/4.13/lib/kdf/pbkdf -I /home/opam/.opam/4.13/lib/logs -I /home/opam/.opam/4.13/lib/macaddr -I /home/opam/.opam/4.13/lib/mirage-crypto -I /home/opam/.opam/4.13/lib/mirage-crypto-ec -I /home/opam/.opam/4.13/lib/mirage-crypto-pk -I /home/opam/.opam/4.13/lib/mirage-crypto-rng -I /home/opam/.opam/4.13/lib/mirage-crypto-rng/unix -I /home/opam/.opam/4.13/lib/ohex -I /home/opam/.opam/4.13/lib/ptime -I /home/opam/.opam/4.13/lib/re -I /home/opam/.opam/4.13/lib/seq -I /home/opam/.opam/4.13/lib/stdlib-shims -I /home/opam/.opam/4.13/lib/uutf -I /home/opam/.opam/4.13/lib/x509 -I /home/opam/.opam/4.13/lib/zarith -I lib/.tls.objs/byte -I lib/.tls.objs/native -intf-suffix .ml -no-alias-deps -o tests/.key_derivation.eobjs/native/dune__exe__Key_derivation.cmx -c -impl tests/key_derivation.ml) File "tests/key_derivation.ml", line 696, characters 2-36: 696 | Mirage_crypto_rng_unix.use_default () ; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Error: Unbound value Mirage_crypto_rng_unix.use_default ```
capnp-rpc-unix.2.0 is failing but I need it is a mirage-crypto bound, not a bound on tls, that is needed |
…a deprecation alert
@mseri added |
Transport Layer Security purely in OCaml
CHANGES:
(use dune variants and mirage-crypto 1.2.0 API mirleft/ocaml-tls#513 @hannesm)