forked from rubocop/rubocop-rails
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathwhere_equals.rb
98 lines (82 loc) · 3.1 KB
/
where_equals.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
# frozen_string_literal: true
module RuboCop
module Cop
module Rails
# This cop identifies places where manually constructed SQL
# in `where` can be replaced with `where(attribute: value)`.
#
# @example
# # bad
# User.where('name = ?', 'Gabe')
# User.where('name = :name', name: 'Gabe')
# User.where('name IS NULL')
# User.where('name IN (?)', ['john', 'jane'])
# User.where('name IN (:names)', names: ['john', 'jane'])
# User.where('users.name = :name', name: 'Gabe')
#
# # good
# User.where(name: 'Gabe')
# User.where(name: nil)
# User.where(name: ['john', 'jane'])
# User.where(users: { name: 'Gabe' })
class WhereEquals < Base
include RangeHelp
extend AutoCorrector
MSG = 'Use `%<good_method>s` instead of manually constructing SQL.'
RESTRICT_ON_SEND = %i[where].freeze
def_node_matcher :where_method_call?, <<~PATTERN
{
(send _ :where (array $str_type? $_ ?))
(send _ :where $str_type? $_ ?)
}
PATTERN
def on_send(node)
where_method_call?(node) do |template_node, value_node|
value_node = value_node.first
range = offense_range(node)
column_and_value = extract_column_and_value(template_node, value_node)
return unless column_and_value
good_method = build_good_method(*column_and_value)
message = format(MSG, good_method: good_method)
add_offense(range, message: message) do |corrector|
corrector.replace(range, good_method)
end
end
end
EQ_ANONYMOUS_RE = /\A([\w.]+)\s+=\s+\?\z/.freeze # column = ?
IN_ANONYMOUS_RE = /\A([\w.]+)\s+IN\s+\(\?\)\z/i.freeze # column IN (?)
EQ_NAMED_RE = /\A([\w.]+)\s+=\s+:(\w+)\z/.freeze # column = :column
IN_NAMED_RE = /\A([\w.]+)\s+IN\s+\(:(\w+)\)\z/i.freeze # column IN (:column)
IS_NULL_RE = /\A([\w.]+)\s+IS\s+NULL\z/i.freeze # column IS NULL
private
def offense_range(node)
range_between(node.loc.selector.begin_pos, node.loc.expression.end_pos)
end
def extract_column_and_value(template_node, value_node)
value =
case template_node.value
when EQ_ANONYMOUS_RE, IN_ANONYMOUS_RE
value_node.source
when EQ_NAMED_RE, IN_NAMED_RE
return unless value_node&.hash_type?
pair = value_node.pairs.find { |p| p.key.value.to_sym == Regexp.last_match(2).to_sym }
pair.value.source
when IS_NULL_RE
'nil'
else
return
end
[Regexp.last_match(1), value]
end
def build_good_method(column, value)
if column.include?('.')
table, column = column.split('.')
"where(#{table}: { #{column}: #{value} })"
else
"where(#{column}: #{value})"
end
end
end
end
end
end