Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Serving as a builtin source with Monovertex #2382

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Serving as a builtin source with Monovertex #2382

wants to merge 2 commits into from

Conversation

BulkBeing
Copy link
Contributor

@BulkBeing BulkBeing commented Feb 6, 2025 •
edited by vigith
Loading

Fixes #2350

@codecov Codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 50.54945% with 45 lines in your changes missing coverage. Please review.

Project coverage is 69.76%. Comparing base (4934571) to head (62fc3b0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/serving/src/config.rs 46.03% 34 Missing ⚠️
rust/serving/src/pipeline.rs 0.00% 8 Missing ⚠️
rust/serving/src/app/callback/state.rs 40.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2382      +/-   ##
==========================================
- Coverage   69.81%   69.76%   -0.06%     
==========================================
  Files         361      361              
  Lines       49984    50035      +51     
==========================================
+ Hits        34897    34907      +10     
- Misses      14015    14049      +34     
- Partials     1072     1079       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy Awaiting requested review from whynowy whynowy will be requested when the pull request is marked ready for review whynowy is a code owner

@vigith vigith Awaiting requested review from vigith vigith will be requested when the pull request is marked ready for review vigith is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Monovertex changes to support serving as a builtin source
1 participant
@BulkBeing