Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid checking the response in object service #3095

Open
roman-khimov opened this issue Jan 28, 2025 · 0 comments
Open

Avoid checking the response in object service #3095

roman-khimov opened this issue Jan 28, 2025 · 0 comments
Labels
enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues performance More of something per second S3 Minimally significant U3 Regular

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when we have some unaddressed TODOs.

Describe the solution you'd like

#3092 moves the response eacl check (getrange/search) to the service, but this check is repeated for every chunk and seems to be redundant overall (it's a response and we've already checked if it's OK to perform the action). Check/prove/optimize.
@roman-khimov roman-khimov added enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues performance More of something per second S3 Minimally significant U3 Regular labels Jan 28, 2025
@roman-khimov roman-khimov mentioned this issue Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues performance More of something per second S3 Minimally significant U3 Regular
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roman-khimov