Netmap with nodev2 #3088
Draft
Netmap with nodev2 #3088
+547
−231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3088 +/- ##
==========================================
- Coverage 22.47% 22.38% -0.10%
==========================================
Files 751 749 -2
Lines 57804 58065 +261
==========================================
+ Hits 12991 12995 +4
- Misses 43929 44185 +256
- Partials 884 885 +1 ☔ View full report in Codecov by Sentry. |
roman-khimov
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Jan 23, 2025
We need it for structs to be usable as function parameters, otherwise
they're not implementing stackitam.Convertible and they fail at transaction
script creation phase:
2025/01/22 20:31:26 bootstrap error: could not invoke method (addNode): test invocation failed: unsupported operation: *netmap.NetmapNode2 type
Related to nspcc-dev/neofs-node#3088.
Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Jan 23, 2025
We need it for structs to be usable as function parameters, otherwise
they're not implementing stackitam.Convertible and they fail at transaction
script creation phase:
2025/01/22 20:31:26 bootstrap error: could not invoke method (addNode): test invocation failed: unsupported operation: *netmap.NetmapNode2 type
Related to nspcc-dev/neofs-node#3088.
Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Jan 24, 2025
We need it for structs to be usable as function parameters, otherwise
they're not implementing stackitam.Convertible and they fail at transaction
script creation phase:
2025/01/22 20:31:26 bootstrap error: could not invoke method (addNode): test invocation failed: unsupported operation: *netmap.NetmapNode2 type
Related to nspcc-dev/neofs-node#3088.
Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Jan 24, 2025
We need it for structs to be usable as function parameters, otherwise
they're not implementing stackitam.Convertible and they fail at transaction
script creation phase:
2025/01/22 20:31:26 bootstrap error: could not invoke method (addNode): test invocation failed: unsupported operation: *netmap.NetmapNode2 type
Related to nspcc-dev/neofs-node#3088.
Signed-off-by: Roman Khimov <[email protected]>
Useless, NodeInfo can be passed directly and InvokePrmOptional is never used. Signed-off-by: Roman Khimov <[email protected]>
But only if not converted to v2 node yet. We're keeping both for old networks till they make a switch, then only v2 nodes are used. Signed-off-by: Roman Khimov <[email protected]>
It's not adding any value. Signed-off-by: Roman Khimov <[email protected]>
This logic is present since 2bd827a, but sending tx every epoch is simpler and more reliable. The overhead is negligible. Signed-off-by: Roman Khimov <[email protected]>
Most of the time we don't need a complete AddPeer/AddNode. Fixes #1914. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
It's not provided for NodeV2, most of the time we need the latest and greatest, when we don't usually epoch is known, so this interface is not really needed. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
It's not expected to be used, but semantically it's very much similar to Array's PACK. Signed-off-by: Roman Khimov <[email protected]>
Simiilar to PACK/PACKSTRUCT, but takes twice as manu arguments. Signed-off-by: Roman Khimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3047, fixes #1914. The logic is rather simple:
Related to nspcc-dev/neofs-contract#461, once it's there the default will be to use v2 for new installations.