Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop supporting OID object search V2 #319

Open
cthulhu-rider opened this issue Jan 24, 2025 · 1 comment
Open

Stop supporting OID object search V2 #319

cthulhu-rider opened this issue Jan 24, 2025 · 1 comment
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U2 Seriously planned
Milestone

Comments

@cthulhu-rider
Copy link
Contributor

Is your feature request related to a problem? Please describe.

search queries may contain

// * $Object:objectID \
// object_id
filter. These filters make almost no sense since they can only exclude specific objects from the result, and:

  • NOT_PRESENT and NUM* matchers always exclusive
  • PREFIX is ​​not usable because the values ​​are hashes
  • EQ is no-op

so, only NE matcher as a way to prevent 1 particular object to be included into result. The practical benefit is also questionable:

  • the amount of data transferred will be reduced only if attributes are requested, and only if the object is matched. Otherwise, in the first case it is the same, in the second - even more
  • the apps work with specific IDs is not such a frequent situation. Even if it exists, ignoring the objects in a result is much more natural and simple behavior than explicit exclusion from the search query

to sum it up, I don't see any point in supporting such search filters at the moment. Of all the client apps I know, not a single one uses it

Describe the solution you'd like

  • do not support the filter in SearchV2, write doc statement bout this
  • deprecate it for Search

Describe alternatives you've considered

try to find any benefit for apps

Additional context

@cthulhu-rider cthulhu-rider added discussion Open discussion of some problem enhancement Improving existing functionality labels Jan 24, 2025
@cthulhu-rider
Copy link
Contributor Author

#318 (comment) too

@roman-khimov roman-khimov added this to the v2.17.0 milestone Jan 24, 2025
@roman-khimov roman-khimov added U2 Seriously planned S3 Minimally significant I3 Minimal impact and removed discussion Open discussion of some problem labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I3 Minimal impact S3 Minimally significant U2 Seriously planned
Projects
None yet
Development

No branches or pull requests

2 participants