🐛 Bug Report: translations are missing in the notification centre

[parsch]

📜 Description

While https://github.com/novuhq/novu/blob/main/packages/notification-center/src/i18n/languages/en.ts contains 8 strings, most other languages contain 5 strings only. The missing strings are removeMessage, markAsRead and markAsUnRead.

This leads to language confusions in the notification centre, for example with i18n="de" showing a mixture of German and English strings.

I could provide following translations: da, de, fr, it

👟 Reproduction steps

Add a different language than English to the NovuProvider:

<NovuProvider i18n="de">
  <PopoverNotificationCenter>
    {({ unseenCount }) => <NotificationBell unseenCount={unseenCount} />}
  </PopoverNotificationCenter>
</NovuProvider>

👍 Expected behavior

All translations within the notification centre should be in German.

👎 Actual Behavior with Screenshots

Translations for removeMessage, markAsRead and markAsUnRead are missing and the English strings are being displayed instead.

Novu version

Novu SaaS

npm version

NA

node version

NA

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

• I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines

Are you willing to submit PR?

Yes I am willing to submit a PR!

[linear]

NV-3322 🐛 Bug Report: translations are missing in the notification centre

[scopsy]

@parsch if I understand correctly you are willing to help with those languages? Assigning you 🙏

[parsch]

@scopsy I'll start with an overview of the languages for which the strings removeMessage, markAsRead and markAsUnRead are missing; all respective files are located at /packages/notification-center/src/i18n/languages/.

Checked languages contain all strings (or will be covered in an upcoming pull request).

In case anyone can help with translations, here's the English version as reference.

{
  notifications: 'Notifications',
  markAllAsRead: 'Mark all as read',
  poweredBy: 'Powered By',
  settings: 'Settings',
  removeMessage: 'Remove Message',
  markAsRead: 'Mark as Read',
  markAsUnRead: 'Mark as Unread',
  noNewNotification: 'Nothing new to see here yet',
}

• af
• am
• ar
• as
• az
• ba
• be
• bg
• bh
• bn
• bs
• ca
• cs
• da
• de
• el
• en
• es
• eu
• fa
• fi
• fr
• ga
• gl
• gu
• he
• hi
• hr
• hu
• hy
• id
• ig
• it
• ja
• ka
• kk
• km
• kn
• ko
• ku
• lo
• lt
• lv
• ml
• mr
• ms
• nb
• ne
• nl
• or
• pa
• pl
• pt
• ro
• ru
• sa
• sd
• si
• sm
• sq
• sv
• ta
• te
• th
• tl
• tr
• uk
• ur
• uz
• vi
• zh
• zu

[parsch]

@scopsy out of curiosity: how did you come up with all existing translations? I'm happy to help with this issue, just wondering how I could support this beyond updating languages I'm somehow familiar with.

[scopsy]

All translations are contributed by community members, so it might take a while to get to full availability on all languages 😃

[sieratwb]

I can provide a translation in Simplified Chinese but I'm not a developer and don't know how to contribute, maybe someone can do it?

{
notifications: '通知中心',
markAllAsRead: '将所有设为已读',
poweredBy: '{Novu}提供技术支持',
settings: '设置',
removeMessage: '移除消息',
markAsRead: '设为已读',
markAsUnRead: '设为未读',
noNewNotification: '目前没有新消息',
}

[parsch]

Thanks @sieratwb, I'll integrate that.