Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should not throw JS errors when a merchant does not have appropriate ACL permissions #7478

Open
skoshelev opened this issue Jan 1, 2025 · 0 comments
Assignees
Labels

Comments

@skoshelev
Copy link
Contributor

skoshelev commented Jan 1, 2025

nopCommerce version: 4.80

If the user does not have rights to some functionality, such as viewing orders or attributes, then the corresponding grids generate alerts; instead, it is better to hide the corresponding block simply.

For example, do not display "Purchased with orders" block (the product edit page) when the current user does not have a "View orders" permission

@skoshelev skoshelev added the bug label Jan 1, 2025
@skoshelev skoshelev self-assigned this Jan 1, 2025
@AndreiMaz AndreiMaz changed the title ACL. Do not display blocks on the product edit page for which there are no rights Do not display "Purchased with orders" block (the product edit page) when the current user does not have a "View orders" permission Jan 1, 2025
@AndreiMaz AndreiMaz changed the title Do not display "Purchased with orders" block (the product edit page) when the current user does not have a "View orders" permission We should not throw JS errors when a merchant does not have appropriate ACL permissions Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant