Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multilanguage support #4

Open
Turtle6665 opened this issue Dec 1, 2023 · 0 comments
Open

Multilanguage support #4

Turtle6665 opened this issue Dec 1, 2023 · 0 comments

Comments

@Turtle6665
Copy link

Turtle6665 commented Dec 1, 2023 •
edited
Loading

Hello,

It would be very nice to have the ability to use this packages with non-English songs. To what I see, you are using Wisper-Timestamp witch has a multilingual support but for now, English is hard coded in the package :
https://github.com/karaokenerds/python-lyrics-transcriber/blob/60d691e5c3c405a4029c998ab81431589e2ebd70/lyrics_transcriber/transcriber.py#L775

Maybe the LyricsTranscriber init could have a language argument which will be saved in the class and used in the transcribe() method ? The default value could be None and not "en" as this is the default value in Wisper-Timestamp, and it then detects the language as explained here.

At first glance, it looks like there is no another place in the code that is language related, so it might be an easy fix. Anyway, I will try to test this weekend.

UPDATE : it's not an as easy fix, the model has to change as well...

Have a nice day
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Turtle6665