Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio-Separator-UI #164

Open
Bebra777228 opened this issue Dec 9, 2024 · 2 comments
Open

Audio-Separator-UI #164

Bebra777228 opened this issue Dec 9, 2024 · 2 comments

Comments

@Bebra777228
Copy link
Contributor

Repository Link: Audio-Separator-UI
PyPI Link: PyPI Audio-Separator-UI
I also made minor changes to the interface and described them in the README.

I have also sent you a collaborator invitation. You can accept it and make any necessary changes to my repository.

Regarding the package, I decided to synchronize the versions. You have 0.25.0, and so do I. If you have an update, I will update mine as well. The Gradio interface does not require significant changes, and all modifications occur within a single file. Therefore, I believe this is a reasonable approach. Given that the interface is already ready for use and there is practically nothing to change, the only thing left is to keep this repository in sync with yours.

And I hope I did everything right :)

@beveradb
Copy link
Collaborator

Hey @Bebra777228 - this is your choice (as it's your repo/project) but I would encourage you to change your code for Audio-Separator-UI so it's just including audio-separator as a python dependency, not copying / duplicating all of the code from this repo 😅

That way there's a lot less code to maintain in that repo, you don't need to be constantly pulling in any changes from this repo into your own, etc. - it's also generally best practice to avoid duplicating code wherever possible.

I know I'm a bit of a hypocrite as most of the model inferencing code in this repo comes directly from the UVR codebase, but there was no way for me to use that as a library (which is actually why I built this project!) whereas audio-separator is 100% designed to be useful as a library 😄

Hope that makes sense - if you're not sure how to actually do this, I can potentially raise a PR on your repo showing what I mean but it'll be a pretty big PR deleting most of the code except the gradio UI stuff!

@Bebra777228
Copy link
Contributor Author

Yes, I have a general idea of how to implement this, but if it's not too much trouble, it would be great if you could raise a PR. I might have misunderstood some parts, so your guidance would be really helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants