Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.3.1 #20

Closed
jp4g opened this issue Oct 2, 2024 · 0 comments
Closed

Release v0.3.1 #20

jp4g opened this issue Oct 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jp4g
Copy link

jp4g commented Oct 2, 2024

Problem

  1. release 0.3.0 references noir_bignum v0.3.3 which has an issue https://github.com/noir-lang/noir-bignum/issues/25. This was resolved in noir_bignum 0.3.4 which is included here in commit 499a7f8 but is not released

  2. See request for release 0.3.5 of noir_bignum- there is an additional compilation issue I won't redetail here. But in order for noir_rsa to compile with aztec-nargo, the non-ascii characters in upstream noir_bignum must be removed from the comments.

Happy Case

Would be nice to have a quick tagged release of noir_rsa 0.3.1 including described bump to noir_bignum 0.3.5 so that we can specify the dependency without local bash scripting to fix/ cloned repos

Afaik you can't patch nargo.toml if you can though pls ignore

Workaround Description

Clone downstream repositories and change dependencies, potentially pushing to forked library if critical

@jp4g jp4g added the enhancement New feature or request label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants