From 3edaf3479cf54e1a9dc0d4fcacd45db0faa2ec26 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Pedro=20Sousa?= Date: Fri, 29 Nov 2024 13:17:53 +0000 Subject: [PATCH 1/3] feat: adding default trait impl --- src/bignum.nr | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/bignum.nr b/src/bignum.nr index 52002bd7..1b5eab67 100644 --- a/src/bignum.nr +++ b/src/bignum.nr @@ -17,6 +17,17 @@ use crate::fns::{ pub struct BigNum { pub limbs: [Field; N], } + + +impl Default for BigNum +where + Params: BigNumParamsGetter, +{ + fn default() -> Self { + BigNum::new() + } +} + // We aim to avoid needing to add a generic parameter to this trait, for this reason we do not allow // accessing the limbs of the bignum except through slices. pub trait BigNumTrait { From c97e8834e8549a5fdb3e0f3ae90e3065777dcdc1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Pedro=20Sousa?= Date: Fri, 29 Nov 2024 20:49:18 +0000 Subject: [PATCH 2/3] formatting --- src/bignum.nr | 4 ++-- src/fns/constrained_ops.nr | 3 ++- src/runtime_bignum.nr | 3 ++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/bignum.nr b/src/bignum.nr index 1b5eab67..d9927567 100644 --- a/src/bignum.nr +++ b/src/bignum.nr @@ -6,7 +6,8 @@ use crate::fns::{ constrained_ops::{ add, assert_is_not_equal, conditional_select, derive_from_seed, div, eq, mul, neg, sub, udiv, udiv_mod, umod, validate_in_field, validate_in_range, - }, expressions::{__compute_quadratic_expression, evaluate_quadratic_expression}, + }, + expressions::{__compute_quadratic_expression, evaluate_quadratic_expression}, serialization::{from_be_bytes, to_le_bytes}, unconstrained_ops::{ __add, __batch_invert, __batch_invert_slice, __derive_from_seed, __div, __eq, __invmod, @@ -18,7 +19,6 @@ pub struct BigNum { pub limbs: [Field; N], } - impl Default for BigNum where Params: BigNumParamsGetter, diff --git a/src/fns/constrained_ops.nr b/src/fns/constrained_ops.nr index 758e23dc..30ded4ea 100644 --- a/src/fns/constrained_ops.nr +++ b/src/fns/constrained_ops.nr @@ -5,7 +5,8 @@ use crate::fns::{ unconstrained_helpers::{ __add_with_flags, __neg_with_flags, __sub_with_flags, __validate_gt_remainder, __validate_in_field_compute_borrow_flags, - }, unconstrained_ops::{__div, __mul, __udiv_mod}, + }, + unconstrained_ops::{__div, __mul, __udiv_mod}, }; /** diff --git a/src/runtime_bignum.nr b/src/runtime_bignum.nr index 0325ca54..ec141ebd 100644 --- a/src/runtime_bignum.nr +++ b/src/runtime_bignum.nr @@ -5,7 +5,8 @@ use crate::fns::{ constrained_ops::{ add, assert_is_not_equal, conditional_select, derive_from_seed, div, eq, mul, neg, sub, udiv, udiv_mod, umod, validate_in_field, validate_in_range, - }, expressions::{__compute_quadratic_expression, evaluate_quadratic_expression}, + }, + expressions::{__compute_quadratic_expression, evaluate_quadratic_expression}, serialization::{from_be_bytes, to_le_bytes}, unconstrained_ops::{ __add, __batch_invert, __batch_invert_slice, __derive_from_seed, __div, __eq, __invmod, From 0302e03ff4b09568a2c337146d844c1a105b7807 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Pedro=20Sousa?= Date: Fri, 29 Nov 2024 20:52:58 +0000 Subject: [PATCH 3/3] formatting --- src/bignum.nr | 3 +-- src/fns/constrained_ops.nr | 3 +-- src/runtime_bignum.nr | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/bignum.nr b/src/bignum.nr index d9927567..e8069688 100644 --- a/src/bignum.nr +++ b/src/bignum.nr @@ -6,8 +6,7 @@ use crate::fns::{ constrained_ops::{ add, assert_is_not_equal, conditional_select, derive_from_seed, div, eq, mul, neg, sub, udiv, udiv_mod, umod, validate_in_field, validate_in_range, - }, - expressions::{__compute_quadratic_expression, evaluate_quadratic_expression}, + }, expressions::{__compute_quadratic_expression, evaluate_quadratic_expression}, serialization::{from_be_bytes, to_le_bytes}, unconstrained_ops::{ __add, __batch_invert, __batch_invert_slice, __derive_from_seed, __div, __eq, __invmod, diff --git a/src/fns/constrained_ops.nr b/src/fns/constrained_ops.nr index 30ded4ea..758e23dc 100644 --- a/src/fns/constrained_ops.nr +++ b/src/fns/constrained_ops.nr @@ -5,8 +5,7 @@ use crate::fns::{ unconstrained_helpers::{ __add_with_flags, __neg_with_flags, __sub_with_flags, __validate_gt_remainder, __validate_in_field_compute_borrow_flags, - }, - unconstrained_ops::{__div, __mul, __udiv_mod}, + }, unconstrained_ops::{__div, __mul, __udiv_mod}, }; /** diff --git a/src/runtime_bignum.nr b/src/runtime_bignum.nr index ec141ebd..0325ca54 100644 --- a/src/runtime_bignum.nr +++ b/src/runtime_bignum.nr @@ -5,8 +5,7 @@ use crate::fns::{ constrained_ops::{ add, assert_is_not_equal, conditional_select, derive_from_seed, div, eq, mul, neg, sub, udiv, udiv_mod, umod, validate_in_field, validate_in_range, - }, - expressions::{__compute_quadratic_expression, evaluate_quadratic_expression}, + }, expressions::{__compute_quadratic_expression, evaluate_quadratic_expression}, serialization::{from_be_bytes, to_le_bytes}, unconstrained_ops::{ __add, __batch_invert, __batch_invert_slice, __derive_from_seed, __div, __eq, __invmod,