Add global setup/teardown hooks for test suites #256
+121
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey -- sorry about missing this earlier. Been thinking about it for a few days. How do you feel about letting you change the name of the function instead? That way you can have your own main that does setup and teardown. |
|
I like your suggestion of allowing users to write their own main function, it would actually be a better solution since it would allow sharing data between setup and teardown without having to use statics. Feel free to close this PR if you want to go with that instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251
I tried to keep it simple and use what was already available in the macro.
Adding more info for setup/teardown could be nice but it involves changing a lot of stuff, and it can (partially) be done externally by hooking your own tests.