Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit fetching of rows to a certain threshold #1508

Open
blizzz opened this issue Dec 16, 2024 · 6 comments
Open

Limit fetching of rows to a certain threshold #1508

blizzz opened this issue Dec 16, 2024 · 6 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request performance Performance issues and optimisations

Comments

@blizzz
Copy link
Member

blizzz commented Dec 16, 2024

Contributes to #941

Currently the frontend tries to load all rows from a table or view. This is currently not a problem in rendering, but can be a problem for loading times, client RAM usage, and limit of roughly 65k/3 in Postgres that we may run against in the current approach.

In #1507 we prepare a backend API that can take necessary parameters to do effective pagination, even with dynamic values provided.

In a first step we want to limit the maximum number of rows to be fetched, while keeping the current pagination system. When requesting the value, dynamic filters and sorting rules shall also be supplied with the query.

The frontend shall request to load 1101 rows (eleven complete pages, plus and indicator of 1 for more rows). If there are more data rows available, the user shall be informed by a message with the hint that filtered loading and sorting can finetune the result set.

Internally, we store the information whether this table or view is loaded fully or just partially.

@blizzz blizzz added 1. to develop Accepted and waiting to be taken care of enhancement New feature or request performance Performance issues and optimisations labels Dec 16, 2024
@enjeck
Copy link
Contributor

enjeck commented Dec 20, 2024

to load 1101 rows (eleven complete pages, plus and indicator of 1 for more rows)

Why/How did we choose this number? As in, why not 1001, for example?

@ISC-PRO
Copy link

ISC-PRO commented Jan 6, 2025

Good morning. Can the number of rows be limited in customizing or table settings?

@blizzz
Copy link
Member Author

blizzz commented Jan 6, 2025

to load 1101 rows (eleven complete pages, plus and indicator of 1 for more rows)

Why/How did we choose this number? As in, why not 1001, for example?

The thought behind is is the current page (100 rows) plus 5 pages before and after (25100), plus 1 for an indicator whether there are more entries.

@blizzz
Copy link
Member Author

blizzz commented Jan 6, 2025

Good morning. Can the number of rows be limited in customizing or table settings?

At the moment it is unlimited, so anything that we come up with should be more performant. It has the most effect on the browser, and that can be very individual from laptops and PCs with loads of RAM to puny phones and old devices with little RAM. So ideally we can figure out a good number dynamically, if needed. I would refrain from a setting for this.

@ISC-PRO
Copy link

ISC-PRO commented Jan 6, 2025

Good morning. Can the number of rows be limited in customizing or table settings?

At the moment it is unlimited, so anything that we come up with should be more performant. It has the most effect on the browser, and that can be very individual from laptops and PCs with loads of RAM to puny phones and old devices with little RAM. So ideally we can figure out a good number dynamically, if needed. I would refrain from a setting for this.

Paging is currently displayed. But 100 rows are too many for our users. We would like to limit the number to 25 per page. Can I make this setting?

@blizzz
Copy link
Member Author

blizzz commented Jan 6, 2025

It is displayed, but it is fake in so far as all rows are being loaded at once (but it is not heavy on the browser). The number is hard coded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request performance Performance issues and optimisations
Projects
None yet
Development

No branches or pull requests

3 participants