Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with links to a file within a markdown text field #1500

Open
larmarange opened this issue Dec 13, 2024 · 2 comments
Open

Bug with links to a file within a markdown text field #1500

larmarange opened this issue Dec 13, 2024 · 2 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working needs info Not enough information provided

Comments

@larmarange
Copy link

Steps to reproduce

  1. A table with a text column (rich markodwn text)
  2. Create a record. In the text field, add a link (use the link icon), select link to a file, and select a file.

Expected behavior

When clicking on the generated link, having access to the corresponding file

Actual behavior

The current link contains the relative to a file, i.e. the ULR part following ?dir= in the files app. However, when clicking on it from the table view, this relative path doesn't work.

It would be better if the markdown editor where inserting an internal link rather than this relative path.

I do not know if it should be fixed here in Tables or in the markdown editor app.

Tables app version

0.8.1

Browser

No response

Client operating system

No response

Operating system

No response

Web server

None

PHP engine version

None

Database

None

Additional info

No response

@larmarange larmarange added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Dec 13, 2024
@blizzz
Copy link
Member

blizzz commented Dec 17, 2024

Hi @larmarange and thanks for the report!

In text it seems that the absolute path is added to the markdown document.

But I have the identical behaviour in Tables as well, i.e. cannot reproduce your case with the steps given.

Please update to 0.8.2 and retry. If you still experience the problem, would you mind taking a screen recording? Also please tell us which NC version you are using.

@blizzz blizzz added the needs info Not enough information provided label Dec 17, 2024
@larmarange
Copy link
Author

larmarange commented Dec 17, 2024

Hi @blizzz and thank you for your answer. I have updated Tables to 0.8.2 and all other apps are up to date.

When creating a link to a file in a rick text, I have two options when clicking on a link icon.

Image

Sorry, it is in French.

When using the first option (Link to a file or a folder), its creating in markdown a link with the name of file as the text and a relative link, here Test.docx?fileId=200729 interpreted by the navigator as https://cloud.ceped.org/Test.docx?fileId=200729 which is invalid.

If I use the third option (smart selector) then choose Link to a file or a folder, then it insert in the markdown the follwing absolute link: https://cloud.ceped.org/f/200729#/table/31 and these URL works and point to the corresponding (please note that the `#/table/31``is not very relevant here, but do not break anything).

The two approaches does not generate the same markdown.

Image

Would it be clearer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working needs info Not enough information provided
Projects
None yet
Development

No branches or pull requests

2 participants