Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SCION compiler output checks #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add SCION compiler output checks #25

wants to merge 1 commit into from

Conversation

amdfxlucas
Copy link
Collaborator

@amdfxlucas amdfxlucas commented Jan 25, 2025 •
edited
Loading

for description see #19

@amdfxlucas amdfxlucas requested a review from lschulz January 25, 2025 18:46
@amdfxlucas amdfxlucas self-assigned this Jan 25, 2025
@amdfxlucas amdfxlucas linked an issue Jan 25, 2025 that may be closed by this pull request
Add SCION compiler output checks #19
Open
@amdfxlucas amdfxlucas added the enhancement New feature or request label Jan 25, 2025
lschulz
lschulz requested changes Jan 27, 2025
View reviewed changes
Copy link
Member

@lschulz lschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the source code formatting. Keep line length and maximum degree of nested blocks in check by extracting some sub-functions.

tools/scion/scion-topo-sanitizer.py Outdated
def find_and_check_json_files(directory='.'):
compose = parse_docker_compose_yaml()
services = compose['services']
networks = compose['networks']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable

tools/scion/scion-topo-sanitizer.py Outdated
print('No errors detected')

if __name__ == "__main__":
find_and_check_json_files()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory that is searched for topology files could easily be passed on the command line.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done and documented in the README

@amdfxlucas amdfxlucas force-pushed the scion-topo-sanitizer branch from 2972f78 to 4b090b5 Compare February 6, 2025 16:48
@amdfxlucas amdfxlucas changed the title SCION topology sanitizer add SCION compiler output checks Feb 6, 2025
@amdfxlucas
Copy link
Collaborator Author

implemented the changes we discussed yesterday. [renamed & moved to unittests ]

@amdfxlucas amdfxlucas requested a review from lschulz February 6, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lschulz lschulz Awaiting requested review from lschulz

Requested changes must be addressed to merge this pull request.

Assignees

@amdfxlucas amdfxlucas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SCION compiler output checks
2 participants
@amdfxlucas @lschulz